Michael Bahr

Results 54 comments of Michael Bahr

I've made a bit of progress as in "we now run the step to install playwright dependencies, but fail to do so because of system permissions". See https://buildkite.com/sourcegraph/sourcegraph/builds/264578#018e2d1c-b3b9-420a-8e96-64b447e1d663. I've also...

`playwright install` (with or without extra args) seems blocked, because of permissions. https://buildkite.com/sourcegraph/sourcegraph/builds/264611#018e2d93-f5a9-40c3-b8b8-b851b9567012 ``` Installing dependencies... E: setgroups 65534 failed - setgroups (1: Operation not permitted) ```

No progress on hermetic install either. ## With hermetic env var https://buildkite.com/sourcegraph/sourcegraph/builds/264631#018e2dc5-4475-4a6c-a531-ccd0266d934f ``` ================================================================================ (13:48:31) FAIL: //client/web:playwright_install (see /root/.cache/bazel/_bazel_root/157e7a032b8afdaab0b3a3266b4b5f43/execroot/__main__/bazel-out/k8-fastbuild/testlogs/client/web/playwright_install/test.log) FAILED: //client/web:playwright_install (Summary) /root/.cache/bazel/_bazel_root/157e7a032b8afdaab0b3a3266b4b5f43/execroot/__main__/bazel-out/k8-fastbuild/testlogs/client/web/playwright_install/test.log /root/.cache/bazel/_bazel_root/157e7a032b8afdaab0b3a3266b4b5f43/execroot/__main__/bazel-out/k8-fastbuild/testlogs/client/web/playwright_install/test_attempts/attempt_1.log (13:48:31) INFO: From Testing //client/web:playwright_install: ====================...

Related breaking change where playwright stopped downloading browsers automatically (~7 months ago): https://playwright.dev/docs/release-notes#breaking-changes-playwright-no-longer-downloads-browsers-automatically

Another idea: - instead of npm browser dependencies use http_archive to download a binary into a well-known path and pass that as the browser path env - figure out where...

Main difference between puppeteer and playwright: Puppeteer downloads the browser during `npm install`; playwright has its own CDN and expectations on the folder structure where the apps live. I feel...

I have made some progress and documented on the PR in the meantime: https://github.com/sourcegraph/sourcegraph/pull/60897#issuecomment-2009967872 I solved the install problems above, and now face a different challenge when integrating playwright with...

Good catch! I just added the commit https://github.com/sourcegraph/sourcegraph/pull/60897/commits/c905a5dbd773ffcc0601fac9a15680adc8b2574e which I forgot to create yesterday, and fixed the import there. However I'm still getting the same error. The previous playwright prototype...

@jamesmcnamara Thank you very much for your input! I took some time to investigate the intercept approach you suggested, and while not able to make a test green while intercepting...

@jamesmcnamara Thank you very much! Happy that it turned out a bit easier, that should make it more maintainable in the long term :) I can run the tests locally...