start-server-and-test icon indicating copy to clipboard operation
start-server-and-test copied to clipboard

fix: issue #384 (caused by ps-tree) with modified local version

Open BePo65 opened this issue 1 year ago • 3 comments

ps-tree throws an error, when used on newer windows systems (see issue #384 and indexzero/ps-tree#62).

As ps-tree is quite abandoned (last commit is more than a year old) and as ps-tree contains many vulnerabilities and deprecated packages, perhaps it makes sense to add a local copy of ps-tree with errors fixed.

That is what I did. I added a file containing a modified clone of ps-tree with errors fixed. This way in index.js only the import line had to be modified. Should ps-tree ever get updated, only this line has to be returned to its original state (with ps-tree reinstalled).

BePo65 avatar Nov 27 '24 19:11 BePo65

@bahmutov: is this pr an acceptable way to handle the situation that the package ps-tree seems to be unmaintained?

I created a pr for the problem in ps-tree (see indexzero/ps-tree#62) and created another pr (see indexzero/ps-tree#60) to find out, if this package is still alive. The last commit in indexzero/ps-tree is more than a year old and there are many unfixed vulnerabilities and deprecated dependencies.

My intention was to create a fast solution that easily can be replaced with an official solution (i.e. a fixed version of ps-tree), when that solution should be available.

BePo65 avatar Nov 28 '24 12:11 BePo65

@BePo65

I suggest to close this PR as there is not an urgent need for it and start-server-and-test does not directly use WMIC.

  • Until Microsoft finally removes WMIC, it is possible to use the instructions How to install WMIC Feature on Demand on Windows 11 if WMIC is missing from the system.

  • Wait for resolution (or rejection) of issue https://github.com/indexzero/ps-tree/issues/58 which is where WMIC is being used directly.

MikeMcC399 avatar Nov 30 '24 08:11 MikeMcC399

@BePo65

Happy New Year!

I'm hiding my previous comment as it is now out of date.

  • In the meantime GitHub has released Windows Server 2025 (see https://github.com/bahmutov/start-server-and-test/issues/398) and they have said that they will not add back the WMIC Feature on Demand.
  • The ps-tree repo has turned out to be effectively unmaintained as there is nobody available to release fixes. I have withdrawn my efforts from this repo.

MikeMcC399 avatar Jan 13 '25 08:01 MikeMcC399