cypress-recurse icon indicating copy to clipboard operation
cypress-recurse copied to clipboard

For log:true "NICE!" is getting logged when control exits recursion

Open royarunendu opened this issue 3 years ago • 1 comments

cypress-recurse : 1.13.1 if log: true is set in options then "NICE!" gets logged in the test runner window as well.
In the actual use case is there any use of it?

royarunendu avatar Jan 09 '22 13:01 royarunendu

no, but it is nice to know when the recursion successfully finishes

bahmutov avatar Mar 15 '22 10:03 bahmutov

How about we change that log into something useful? I see that it is nice to know when the recursion finishes, but I feel like having to remember that this library logs "Nice" in this case is a bit annoyting :P

How about we change the log to something along the lines of "Recursion finished successfully" ?

iMarv avatar Nov 22 '22 11:11 iMarv

but that's not nice... :)

bahmutov avatar Nov 22 '22 11:11 bahmutov

"Nice! The recursion finished successfully!" ?

iMarv avatar Nov 22 '22 13:11 iMarv

:tada: This issue has been resolved in version 1.27.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Mar 21 '23 18:03 github-actions[bot]