cypress-movie icon indicating copy to clipboard operation
cypress-movie copied to clipboard

Support gif creation only for failed tests.

Open rsudarson opened this issue 4 years ago • 3 comments

Provide option to create gifs only for failed tests from env configuration.

rsudarson avatar Jul 02 '20 23:07 rsudarson

For a larger number of tests (say 100+), we can share gif as reproducer for test failures. I made changes to generate gif on test failures as well. Please review https://github.com/bahmutov/cypress-movie/commit/6a0d2854cd7b64a61cb78d19a60b95c8c1e985b8

cc @bahmutov

rsudarson avatar Oct 20 '20 10:10 rsudarson

@bahmutov - Can I merge this change?

rsudarson avatar Nov 25 '20 11:11 rsudarson

So instead of just making gif of every failing test by default, why don't we look if this is required. I say grab the environment variable RECORD_FAILED_TESTS and if it is set, then generate (still using || against the test titles).

Then it would be nice and clear

bahmutov avatar Nov 25 '20 16:11 bahmutov