cy-api
cy-api copied to clipboard
Hide options that do not belong to `Cypress.RequestOptions` from "Request:" in the HTML
This does not make a big difference, but I have never found it useful to have this property shown in the HTML.
If you like I can turn it into an option.
Hi @aubincc ! Can you add a testing case please ? Thanks for your contribution !
Hi @aubincc ! Can you add a testing case please ? Thanks for your contribution !
Sure, I'll see if I can have a look. I might even try and make it an option. Do you think I should?
Nice one ! By The Way, I'm thinking that we could elarge this one with more stuff than failOnStatusCode to hide, like:
interface Loggable {
log: boolean
}
interface Failable {
failOnStatusCode: boolean
retryOnStatusCodeFailure: boolean
retryOnNetworkFailure: boolean
}
To only show what's depend on pure request stuff :
interface RequestOptions {
auth: object
body: RequestBody
encoding: Encodings
followRedirect: boolean
form: boolean
gzip: boolean
headers: object
method: HttpMethod
qs: object
url: string
}
What's do you think ?
I think of a question:
showLoggables
/API_SHOW_LOGGABLES
& showFailables
/API_SHOW_FAILABLES
?
API_SHOW_CYPRESS_SPECIFIC_REQUEST_OPTION
for both ?
Alright, please be nice and patient now, today was my first go at TypeScript ever 🥵
I have done it and it is working but I'm running into a little bit of a nightmare when pushing. Could be something to do with the husky pre-push, I don't know.
I'd like a review @LeJeanbono
My next goal would be to convert the qs
object to a real querystring.
Baby steps 👶🏻
Are you done @aubincc ?
Are you done @aubincc ?
Done with the RequestOptions yes, would you care to verify my code?
About the querystring, I will see to that another time.
@LeJeanbono what must I do now?