Dmitry Baev comments

Results 300 comments of


                                            Dmitry Baev

[allure-playwright]: Need a new feature to add an attachment to a step.

what version of allure-playwright are you using?

[allure-playwright]: Need a new feature to add an attachment to a step.

allure-playwright was reworked in 2.0.0-beta.16, could you please confirm that issue still exists

[allure-playwright]: Need a new feature to add an attachment to a step.

https://github.com/microsoft/playwright/issues/14364

Generate allure report for Playwright + Cucumber combination

that's probably because of https://github.com/allure-framework/allure-js/issues/227

Please add support for intern.js

the issue is low priority but you can sponsor it. For more details please contact mailto:[email protected]

Multiple screen diff sections

BTW multiple image diffs are supported by Allure for a while https://github.com/allure-framework/allure2/pull/1145

Multiple screen diff sections

that's because playwright by default doesn't support soft assertions. So we expect only one diff per test. It could (and probably will) be changed at some point, but for now...

Timeout parameter on @Test Annotation does not override Timeout Rule

@kcooney seems like the dirty hack. What about remove `withPotentialTimeout` from `BlockJUnit4ClassRunner#methodBlock`, and manage all timeouts logic in rules? We can access to annotations timeouts `Description#getAnnotations()`. So all we need...

Timeout parameter on @Test Annotation does not override Timeout Rule

@kcooney `withPotentialTimeout` is deprecated at 01.07.09 by Saff with comment "Will be private soon: use Interceptors instead" (see e4c7fac8 ).

Timeout parameter on @Test Annotation does not override Timeout Rule

BTW we can return empty `Statement` instead `FailOnTimeout`. > Calling the `@Before` and `@After` methods use the same thread (and timeout) as the test could also break people, in a...