corebird icon indicating copy to clipboard operation
corebird copied to clipboard

Search: load more doesn't work right

Open Vistaus opened this issue 9 years ago • 4 comments

When I search for something and then click on Load more, it starts to load the exact same accounts instead of other related accounts.

Search results: screenshot from 2017-01-10 20-44-36

After clicking on Load more a few times: screenshot from 2017-01-10 20-44-48

Using Corebird git master on Solus (Linux).

Vistaus avatar Jan 10 '17 19:01 Vistaus

iirc that happens when there are exactly 3 users to show in the users part of the list. When we then query the next 3, the Twitter API returns the same 3 instead of nothing.

baedert avatar Jan 12 '17 08:01 baedert

You're right that there are not many users being found with those search terms but Twitter Mobile shows 4 instead of 3 with that same query. So there must be a bug in either the Twitter API or Corebird...

screenshot from 2017-01-12 09-49-53

Vistaus avatar Jan 12 '17 08:01 Vistaus

Yes, we query 4 entries, then show 3 so we know (so the theory) that if we get more than 3 results, a "show more results" button makes sense, since the next query will return at least one new result. We then get the same ones again unfortunately. (One could argue that not showing the fourth entry is a bug as well but not really the most disturbing one...).

baedert avatar Jan 14 '17 08:01 baedert

I wouldn't say it's a disturbing bug :wink: But I would like to see if fixed. It doesn't have to have high priority or anything but a fix one day in the future would be welcomed :smile_cat:

Vistaus avatar Jan 14 '17 09:01 Vistaus