git2jss icon indicating copy to clipboard operation
git2jss copied to clipboard

Published 20 hours ago • verified publisher icon badstreff

Jamf Pro API + refactoring

Open KeplerKid opened this issue 4 years ago • 2 comments

Now uses the Jamf Pro API to:

  • GET categories
  • GET/PUT/POST scripts

Created file_contents to reduce code duplication.

Abstracted get_template to be used by both scripts and extension attributes.

Set the default of the limit parameter to 5 and capped it at 25.

KeplerKid avatar Jun 18 '20 18:06 KeplerKid

Wow! This looks really good, at first glance this all looks correct. It will take me some time to review everything. Some of what you've done here I've been meaning to but have not found the time.

Thanks!

badstreff avatar Jun 18 '20 19:06 badstreff

It seems this pull request removes the ability to create new scripts. If the ID is missing from the XML it does catch that, but never creates the script in Jamf.

fveja avatar Feb 15 '23 21:02 fveja