StepperView icon indicating copy to clipboard operation
StepperView copied to clipboard

Add macOS support implement #46

Open jevonmao opened this issue 3 years ago • 3 comments

Description

Added macOS support by adding macOS specifier to package.swift file. No other change is made to the codebase.

Note: Adding macOS support will break some examples usage that uses class such as UIColor and UIScreen, @badrinathvm you might want to update those examples.

Type of change

  • [ ] Bug fix
  • [x] New feature
  • [ ] Breaking change
  • [ ] This change requires a documentation update

How Has This Been Tested

No additional unit test added.

Test Configuration

  • Xcode version: 12.5
  • Device/Simulator: Simulator iPhone iOS 15
  • iOS version: 15.0
  • MacOSX version: 11.5 Beta

Checklist:

For checklist items not applicable, mention NA in front of it with some comment if applicable.

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] Add comments to code particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes before pushing the pull request

jevonmao avatar Jun 19 '21 18:06 jevonmao

Thank you for PR. I will have look at breaking examples and add necessary availability checks.

badrinathvm avatar Jun 19 '21 19:06 badrinathvm

Also can u update in podspec file as well for macOS ?

badrinathvm avatar Jun 19 '21 19:06 badrinathvm

Also can u update in podspec file as well for macOS ?

@badrinathvm, Done.

Adding macOS support will break some examples usage that uses class such as UIColor and UIScreen

Also, I adopted all the example views for macOS by changing existing code to cross-platform APIs.

jevonmao avatar Jun 19 '21 22:06 jevonmao