Fix bottomConstraint calculation bug when rendering custom keyboards (such as Microsoft Swiftkey) for the first time

Open esilverberg opened this issue 3 years ago • 6 comments

This PR addresses issue: https://github.com/badoo/Chatto/issues/708

I did my best to limit the scope of this change and fit things into the patterns established in KeyboardTracker.swift

If you all have feedback or preferences for how to do this differently I am happy to oblige. This bug is a 100% repro (see video in the associated bug report) so should be easy to repro on your end if you want to go a different direction.

May 21 '21 02:05 esilverberg

Codecov Report

Merging #710 (c70ad64) into master (db83dec) will increase coverage by 0.09%. The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   59.07%   59.17%   +0.09%     
==========================================
  Files         101      101              
  Lines        5229     5239      +10     
==========================================
+ Hits         3089     3100      +11     
+ Misses       2140     2139       -1

Impacted Files	Coverage Δ
...ChatController/Collaborators/KeyboardTracker.swift	`63.19% <61.53%> (-0.87%)`	:arrow_down:
...Chat Items/TextMessages/Views/TextBubbleView.swift	`85.71% <0.00%> (+3.17%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db83dec...c70ad64. Read the comment docs.