shields icon indicating copy to clipboard operation
shields copied to clipboard

chrome web store badges failing

Open chris48s opened this issue 1 year ago • 2 comments

Are you experiencing an issue with...

shields.io

🐞 Description

All chrome web store badges failing - underlying error is FetchError: maximum redirect reached

/cc @ParticleCore

🔗 Link to the badge

https://img.shields.io/chrome-web-store/rating/ogffaloegjglncjfehdfplabnoondfjo

💡 Possible Solution

We interact with chrome web store via a package: https://www.npmjs.com/package/webextension-store-meta

As a starting point I've raised an issue upstream at https://github.com/awesome-webextension/webextension-store-meta/issues/2

We might need to look into contributing a fix to the upstream lib ourselves. I guess something has changed in chrome web store itself that needs accounting for when we call it :crossed_fingers:

chris48s avatar Feb 13 '24 18:02 chris48s

Badge tested using npm run badge https://img.shields.io/chrome-web-store/rating/ogffaloegjglncjfehdfplabnoondfjo Output is available here

github-actions[bot] avatar Feb 13 '24 18:02 github-actions[bot]

I guess something has changed in chrome web store itself that needs accounting for when we call it

A major redesign and domain change was released

mnoorenberghe avatar Feb 14 '24 06:02 mnoorenberghe

Most of these are fixed (users, version, rating, etc), but we had to drop the price badges as the data is no longer available.

chris48s avatar Feb 18 '24 20:02 chris48s

it seems be still failing for some extensions? https://img.shields.io/chrome-web-store/stars/hkgmldnainaglpjngpajnnjfhpdjkohh image got inaccessible, have to grant some permission thingy in webstore side settings?

sinsinpub avatar Feb 27 '24 14:02 sinsinpub

it seems be still failing for some extensions? https://img.shields.io/chrome-web-store/stars/hkgmldnainaglpjngpajnnjfhpdjkohh image got inaccessible, have to grant some permission thingy in webstore side settings?

I imagine it might be having trouble with the extension name containing a special character () in the url: https://chromewebstore.google.com/detail/kancolle-command-center-改/hkgmldnainaglpjngpajnnjfhpdjkohh

ParticleCore avatar Feb 27 '24 15:02 ParticleCore

@sinsinpub I've raised this upstream https://github.com/awesome-webextension/webextension-store-meta/issues/2#issuecomment-1967382590

chris48s avatar Feb 27 '24 18:02 chris48s

it seems be still failing for some extensions? https://img.shields.io/chrome-web-store/stars/hkgmldnainaglpjngpajnnjfhpdjkohh image got inaccessible, have to grant some permission thingy in webstore side settings?

I imagine it might be having trouble with the extension name containing a special character () in the url: https://chromewebstore.google.com/detail/kancolle-command-center-改/hkgmldnainaglpjngpajnnjfhpdjkohh

yea, might be a case. have tried servral extensions with CJK character name, got the same issue. some handling of url encoding/deocoding needed for upstream?

sinsinpub avatar Feb 27 '24 19:02 sinsinpub

Hi, I have recently fixed the FetchError issue with non-ASCII characters in the upstream webextension-store-meta library, and the patch is included in its v1.2.0 version. This version should fix the issue.

xmcp avatar Apr 10 '24 06:04 xmcp