shields icon indicating copy to clipboard operation
shields copied to clipboard

Migrate daily service tests to GitHub actions

Open chris48s opened this issue 2 years ago • 2 comments

:clipboard: Description

Having migrated all the CI on this repo from Circle CI to GHA, now its time to do the same on https://github.com/badges/daily-tests

I think if I was implementing this from scratch today, I would just set up a scheduled job to run on this repo, like this one:

https://github.com/badges/shields/blob/e8c42e9ec1b2d93790133a7843b04f4a9869cec7/.github/workflows/draft-release.yml#L2-L5

@calebcartwright - Can you remember anything about the rationale for running the daily tests from another repo?

I wonder if we should bring them back into the fold? 🤔

chris48s avatar Jan 17 '23 21:01 chris48s

Is it me, or the daily tests are no longer working at all at this point?

PyvesB avatar Jan 01 '24 11:01 PyvesB

Yeah the daily runs on https://github.com/badges/daily-tests no longer work.

I can't remember exactly when they broke, but it was quite a while back. I decided that instead of putting the time into fixing up that old Circle CI config, I'd rather put the time into moving the daily runs onto scheduled GH actions in this repo. They'll be way easier to keep in sync that way, rather than having to coordinate changes across 2 repos.

But then I ended up doing neither of those things.

chris48s avatar Jan 01 '24 13:01 chris48s

https://github.com/badges/shields/pull/10320 adds a daily tests repo back to the repo. I would still like to add coverage reports to that though.

chris48s avatar Jul 03 '24 17:07 chris48s

#10340 took care of code coverage, closing this issue! 🚀

PyvesB avatar Jul 12 '24 13:07 PyvesB