shields icon indicating copy to clipboard operation
shields copied to clipboard

Published 20 hours ago • verified publisher icon badges

[DockerSize] Docker image size multi arch

Open PaulaBarszcz opened this issue 2 years ago • 1 comments

Related issue: https://github.com/badges/shields/issues/8238

I finished the code implementation for this one, but I would like to make sure that my approach is correct before proceeding to writing tests. All of my changes are pushed to the feature branch (docker-imageSize-multiArch).

PaulaBarszcz avatar Aug 06 '22 21:08 PaulaBarszcz

Messages
:book: :sparkles: Thanks for your contribution to Shields, @PaulaBarszcz!

Generated by :no_entry_sign: dangerJS against 489619cabdb8ca805e519627686fa1b9401d81bd

shields-ci avatar Aug 06 '22 21:08 shields-ci

Hi @chris48s, Thank you for all your suggestions, I finished this batch of corrections and updated tests.

This PR is ready to be reviewed.

PaulaBarszcz avatar Aug 11 '22 16:08 PaulaBarszcz

Hi @chris48s, Thanks for your review; I applied your suggestions. This PR is ready to be re-reviewed.

Who closes discussions in PRs - the author of the comment/suggestion, or the author of the PR (once the changes are implemented)?

PaulaBarszcz avatar Aug 22 '22 18:08 PaulaBarszcz

Hi @chris48s, Thanks for your suggestion regarding valid architectures. The changes are already pushed to the feature branch.

This PR is ready to be re-reviewed.

PaulaBarszcz avatar Aug 25 '22 12:08 PaulaBarszcz