shields
shields copied to clipboard
Add Favicons (high res)
Fix #1497...
🤞hopefully it works now, at least all test passed locally
Messages | |
---|---|
:book: | :sparkles: Thanks for your contribution to Shields, @jaas666! |
Generated by :no_entry_sign: dangerJS against 58f331e72376d8636d153da7d89b943878dc1751
I would have liked to make the files available in some folder and simply add links to the files instead of importing them but couldn't find how to do it. If anyone knows and can give me hand I'd be more than willing to resubmit
Thanks for sticking with it! This seems to be in good order to me, but I'm going to hold off on merging so that some of the more UX minded/skilled maintainers can weigh in
Perfect, thanks.
@paulmelnikow assuming this is one you'd want to based on discussion in the linked issue and prior PR, but let us know if that's not the case and/or if you don't have bandwidth at this time
Yes.. I started from scratch to make it work. Couldn't get previous PR to work.
Is there something wrong ?
Is there something wrong ?
No, at least not necessarily. It's just that the best folks to review this haven't had the bandwidth to do so yet. Please sit tight, and thanks again for your patience and contribution!
Got it No problem.
On Sat, Jun 11, 2022, 7:40 PM Caleb Cartwright @.***> wrote:
Is there something wrong ?
No, at least not necessarily. It's just that the best folks to review this haven't had the bandwidth to do so yet. Please sit tight, and thanks again for your patience and contribution!
— Reply to this email directly, view it on GitHub https://github.com/badges/shields/pull/7983#issuecomment-1153031112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGOB44X6MM4JU7KN6FQL63VOUWYTANCNFSM5WLILAQA . You are receiving this because you were mentioned.Message ID: @.***>