shields icon indicating copy to clipboard operation
shields copied to clipboard

Deprecate [JenkinsPluginInstalls] per version

Open PyvesB opened this issue 1 year ago • 8 comments

The corresponding tests started failing over a month ago, the API is consistently returning an empty installationsPerVersion field. I tried following up on an issue about this, but the response wasn't terribly helpful. I suggest we deprecate the version flavour of the badge, the total installs part of the API still seems to be returning sensible results for now.

PyvesB avatar Dec 15 '24 18:12 PyvesB

Messages
:book: :sparkles: Thanks for your contribution to Shields, @PyvesB!

Generated by :no_entry_sign: dangerJS against 72759540fc4443e6a63aa49c0f407145c632b57b

github-actions[bot] avatar Dec 15 '24 18:12 github-actions[bot]

Where did you raise an issue?

From last time we had an issue with this API it seems https://github.com/jenkins-infra/helpdesk/issues is the place they track issues for this, using the stats.jenkins.io label

chris48s avatar Dec 15 '24 20:12 chris48s

The issue I had found is here: https://github.com/jenkins-infra/stats.jenkins.io/issues/215

From the get go the first few messages in November feel off to me, I kinda got burnt as well, and things have since then escalated to a quarrel between two of the Jenkins maintainers. They're apparently continuing the argument in another issue on https://github.com/jenkins-infra/helpdesk/issues, it's really all a bit ridiculous at this point. I'm not getting involved any further, I don't think it's a good use of my Shields.io time and energy.

PyvesB avatar Dec 15 '24 22:12 PyvesB

For the record we have a separate issue to track the original issue at https://github.com/jenkins-infra/stats.jenkins.io/issues/265. @PyvesB has been asked to follow some suggestions but he would not listen.

krisstern avatar Dec 15 '24 23:12 krisstern

Where did you raise an issue?

From last time we had an issue with this API it seems https://github.com/jenkins-infra/helpdesk/issues is the place they track issues for this, using the stats.jenkins.io label

That's exactly right, the relevant helpdesk issue can be readily found at https://github.com/jenkins-infra/helpdesk/issues/4386.

krisstern avatar Dec 15 '24 23:12 krisstern

Also @PyvesB did not raise a new issue as suggested, but insisted on commenting on an already closed issue in our stats.jenkins.io repo that is not 100% related. I believe the single source of truth should and is always the helpdesk issue cited in https://github.com/badges/shields/pull/10747#issuecomment-2544183643, that's why I did not want to repeat myself or relay anything faulty in the already closed issue.

krisstern avatar Dec 16 '24 00:12 krisstern

Sorry I totally missed track of this one.

Having read over the linked issues, I am also going to refrain from posting in any of these issues but I've followed them for updates.

I think for the moment lets just leave this open and see what happens upstream.

chris48s avatar Dec 29 '24 17:12 chris48s

I have just tried to chase the Jenkins Infra team on this. But it looks like the issue may not be resolved until sometime in January the earliest.

krisstern avatar Dec 30 '24 16:12 krisstern

Installs stats per version are still unavailable at the time of writing: Screenshot 2025-09-20 144256

Our test CI has been reporting failures for close to a year at this point and we've been advertising non-functional badges on our website. This isn't great, will go ahead and merge this. If/when the situation changes on the Jenkins side, we can consider bringing these badges back.

PyvesB avatar Sep 20 '25 12:09 PyvesB