badeggg
badeggg
Does this issue still need proposal?
How do you think of `const [state, setState, stateRef] = useState();`? Inspired by https://github.com/facebook/react/issues/21931 . No need to add new hook and still no break change. And I think `useCallbackRef`...
Think about change https://github.com/react-navigation/react-navigation/blob/52a3234b7aaf4d4fcc9c0155f44f3ea2233f0f40/packages/core/src/useIsFocused.tsx#L16-L23 to: ```tsx React.useEffect(() => { if (isFocused !== valueToReturn) { // If the value has changed since the last render, we need to update it. //...
Think about simply delete https://github.com/react-navigation/react-navigation/blob/52a3234b7aaf4d4fcc9c0155f44f3ea2233f0f40/packages/core/src/useIsFocused.tsx#L16-L23 This code block is for reason that `It is still nice to avoid returning a mismatched value though, so let's override the return value`. But,...
@satya164 Hi, please try codesandbox link again. I forgot to change 'who can access'. https://codesandbox.io/p/sandbox/young-platform-phwfhv?file=%2Fsrc%2FApp.js%3A15%2C24
> Also please provide a repro using where using the hook from React Navigation crashes your code, not an approximation of the logic we have - which may not match...
@satya164 Hi, do you know in what situation, condition `if (isFocused !== valueToReturn)` will be true? I'm trying to make a minimal exact repro, but is struggling to make the...
Yes, I do notice the [Expensify App](https://github.com/Expensify/App) is experiencing that condition met, e.g. [this issue](https://github.com/Expensify/App/issues/42824#issuecomment-2149636667) and [this issue](https://github.com/Expensify/App/issues/42916). The later one only happen on physical iOS. Just, 'expensify app' is...
## Proposal ### Please re-state the problem that we are trying to solve in this issue. Indented text in a quote is not showing correctly ### What is the root...
A little explanation(details) about my [proposal](https://github.com/Expensify/App/issues/38156#issuecomment-2006123806): 1. `row => row.substr(4).trim()` causing leading spaces and trailing spaces of all lines in a quote be removed, which is not actually what we...