snapcast icon indicating copy to clipboard operation
snapcast copied to clipboard

fix Overview on dark bg

Open nim65s opened this issue 1 year ago • 2 comments

Hi,

When github is set on the dark theme, the Overview fig on the README is impossible to read:

dark

A quick fix is to add some colored rectangles behind the black text on transparent background.

nim65s avatar Apr 12 '23 14:04 nim65s

Thanks, I think the clean solution is to use two different images, one for light and one for dark mode, as described here: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to

badaix avatar Jul 14 '23 08:07 badaix

Sure, this could be a better solution than the quickfix I made. But I have no idea how to choose the colors. Here is a render of my solution, for reference. overview

What would you change for the dark mode ?

nim65s avatar Jul 15 '23 08:07 nim65s