Baconplugs dark

[Eurikon]

Hi Paul, could there be a possibility that you could apply the Surge dark theme to your BaconPlugs as well? Or variant thereof?

[baconpaul]

I hadn’t thought of it but the code isn’t dissimilar and both are gpl3 so I guess I could borrow similar ideas. I didn’t think people really used these plugs for much tbh! But happy to add this to the list for when I next open them up

[falkTX]

The commit 2bc40e3a13ad4a9d79ad327abdfe012f6b410805 adds some changes for this, but it is a compile-time option.

Screenshot for easy reference.

[baconpaul]

Hi

I'm in the process of adding a proper dark mode support, using a mechanism I cribbed from the new XT modules, which is in #71 so gonna close this.

[falkTX]

that is very appreciated. I tried to make my changes happen on runtime in your modules, but the heavy caching of GL stuff made that quite complicated and I gave up.

please do tell when finalized, would be great to integrate this with the 22.09-added Cardinal global switch for light vs dark mode (it is basically a bool rack::settings::darkMode global variable). too bad VCV Rack never added an API like this...

[baconpaul]

Yeah I have added an api baconpaul::rackplugs::BaconStyle::setStyle which takes an enum LIGHT or DARK and updates the state accordingly. I'm sure you can hook that into whatever else you need. Right now I have it hooked to a RMB on the module and it works fine (although the style sheets aren't finished yet so some modules still look pretty wonky).

I'm also hiding many of the modules which should be deprecated anyway, just fyi.

[baconpaul]

Anyway next commit will do that

Almost ready to re-up it in the library even. A few more tweaks.

[falkTX]

oh a nice bump in art style/quality too, great to see!

[baconpaul]

its really just better colors and tighter corners on the rectangles. Oh and all the lights moved to the light layer.

And the truly crappy modules i turned off

i wrote this collection in 2017 when rack was at 0.5 and i was still sort of muddling around dsp so a lot of them aren't very good. but i want the module location for some new ideas i have now surge is getting done and i'm composing in rack a bit more.

[baconpaul]

but thanks!

anyway should be ready in a week or so.