Diane Ko
Diane Ko
@nathansh I'm not personally aware of any visually hidden text utilities in this repo (but I also don't regularly contribute to this repo so I don't know if there is...
@nathansh general code change is fine to me! Though it looks like CI is failing? Maybe need to rebase or something
@nathansh Kicked off all the failing jobs again for you - hopefully they pass this time 🤞
hmm.. looks like they're still failing. @ljharb do you know what's going on with the CI checks?
@ljharb any insights here on the failing CI checks?
@nathansh unfortunately I'm not super familiar with this code base specifically (mostly just chime in on a11y questions) and it seems like even in the main branch, CI is failing....
@ljharb do you know if there's any intent to address the underlying issue with what's failing? are all PRs failing at this point?
I can't answer for the linter question, but this repo is much less active from Airbnb folks because we've mostly switched off from using scss to [defining styles in javascript](https://github.com/airbnb/javascript/tree/master/css-in-javascript)...
I like the idea of point 1 so that axe only reports on ids that are being referenced. Also big +1 to point 2 since this has actually come up...
SASS is the older syntax, and doesn't follow CSS style conventions. SCSS was introduced after, and allows you to essentially use CSS and add on to it. This means you...