volsync icon indicating copy to clipboard operation
volsync copied to clipboard

helm: Make chart manage VolSync CRDs

Open JohnStrunk opened this issue 3 years ago • 2 comments

Describe what this PR does Helm will only install CRDs if they are not present. It will not upgrade or remove them. This change switches the CRDs to be managed as a part of the templating mechanism so that they can be upgraded (and removed if necessary).

Is there anything that requires special attention? This is a breaking change for Helm users as noted in the Changelog. In order for a chart upgrade to succeed, users will need to label/annotate the CRDs

Related issues: Fixes #261

JohnStrunk avatar Aug 18 '22 12:08 JohnStrunk

/retest

JohnStrunk avatar Sep 21 '22 16:09 JohnStrunk

/retest

JohnStrunk avatar Oct 12 '22 13:10 JohnStrunk

/hold Investigate leaving CRDs on uninstall

JohnStrunk avatar Oct 12 '22 15:10 JohnStrunk

/unhold /cc @tesshuflower The CRD is now left in the cluster on uninstall

JohnStrunk avatar Oct 12 '22 18:10 JohnStrunk

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.6% 8.6% Duplication

sonarqubecloud[bot] avatar Oct 12 '22 19:10 sonarqubecloud[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 12 '22 19:10 openshift-ci[bot]

/override "SonarCloud Code Analysis"

JohnStrunk avatar Oct 12 '22 19:10 JohnStrunk

@JohnStrunk: Overrode contexts on behalf of JohnStrunk: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 12 '22 19:10 openshift-ci[bot]