mkdocs-techdocs-core icon indicating copy to clipboard operation
mkdocs-techdocs-core copied to clipboard

Line highlighting in codeblocks has changed

Open bforbis opened this issue 1 year ago • 1 comments

I have recently just upgraded mkdocs-techdocs-core from v1.2.3 -> v1.3.5 and have been testing on my documentation smoke test page and noticed a significant change in how codeblock highlighting is visualized using the hl_lines directive.

Version 1.2.3 image

Version ^1.3.3 image

I'm not sure if this was an intentional style change or is a bug, but the new way that line highlighting works is too subtle and easy to miss.

I've done some testing of versions in between and this seems to have been introduced in [email protected], which bumped mkdocs-material to 9.4.14

Looking at the css of the .hll and .highlight CSS class, it looks like the background-color was updated:

Old: background-color: var(--md-code-hl-color) New: background-color: var(--md-code-hl-color--light)

This seems to have been changed in mkdocs-material as reported in https://github.com/squidfunk/mkdocs-material/issues/6017

bforbis avatar Apr 04 '24 15:04 bforbis

Here too. Please fix. Thanks.

pwalleni avatar Apr 10 '24 09:04 pwalleni

Closing as this looks to be fixed in the upstream Backstage repo by https://github.com/backstage/backstage/pull/24809

awanlin avatar Jun 27 '24 18:06 awanlin