mkdocs-techdocs-core icon indicating copy to clipboard operation
mkdocs-techdocs-core copied to clipboard

chore(renovate): refactor config file

Open MindTooth opened this issue 1 year ago • 6 comments

I noticed the config was old and could need a update:

$ renovate-config-validator renovate.json5

 INFO: Validating renovate.json5
 WARN: Config migration necessary
       "oldConfig": {
         "labels": ["dependencies"],
         "extends": ["config:base", ":disableDependencyDashboard", ":gitSignOff"],
         "ignoreDeps": ["mkdocs-material"],
         "packageRules": [{"matchLanguages": ["python"], "rangeStrategy": "widen"}]
       },
       "newConfig": {
         "labels": ["dependencies"],
         "extends": [
           "config:recommended",
           ":disableDependencyDashboard",
           ":gitSignOff"
         ],
         "ignoreDeps": ["mkdocs-material"],
         "packageRules": [{"matchCategories": ["python"], "rangeStrategy": "widen"}]
       }
 INFO: Config validated successfully

  • Changed to using plain .json ending
  • Added schema notation on top
  • Converted to extend
  • Renamed config:base to config:recommended

Question? One question, now that we are on the latest mkdocs-material, should we then remove the ignore and rather split on major/minor so that updates will still be added? Or we can limit updates within the same x.y.


With the changes:

$ renovate-config-validator .github/renovate.json

 INFO: Validating .github/renovate.json
 INFO: Config validated successfully

MindTooth avatar Mar 18 '24 08:03 MindTooth

@johnphilip283 thoughts?

MindTooth avatar Mar 18 '24 08:03 MindTooth

Hey there @MindTooth! Thank you for the PR. We'd like to be on the safer side with mkdocs-material upgrades, so I believe limiting updates within the same x.y would be a nice way to do this. Otherwise, the rest of the changes LGTM!

johnphilip283 avatar Apr 01 '24 17:04 johnphilip283

I've updated the config to use allowedVersions to limit the range.

MindTooth avatar Apr 02 '24 07:04 MindTooth

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Apr 17 '24 01:04 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar May 02 '24 01:05 github-actions[bot]

@johnphilip283 need anything more from me? :smile:

MindTooth avatar May 02 '24 06:05 MindTooth

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar May 17 '24 01:05 github-actions[bot]

Feel like I'm in a whack-a-mole game with the Stale bot. 🤣

whack-a-mole gif

MindTooth avatar May 19 '24 15:05 MindTooth