community-plugins icon indicating copy to clipboard operation
community-plugins copied to clipboard

Migrate orchestrator

Open mareklibra opened this issue 1 year ago • 2 comments

Hey, I just made a Pull Request!

Migrating https://github.com/janus-idp/backstage-plugins/tree/main/plugins/orchestrator under the community plugins.

Based on https://github.com/janus-idp/backstage-plugins/commit/3467654db57df14c46e803d3610361fc5509c9f5 commit.

Created by following https://github.com/backstage/community-plugins/blob/main/CONTRIBUTING.md#manual-migration-steps .

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages. (more info)
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

TODO:

  • [ ] update maintainers
  • [ ] test release
  • [ ] verify dynamic plugins
  • [ ] find/repeat the way how plugins/orchestrator-backend/static/generated/envelope has been generated, make a script for the fufure

mareklibra avatar Jul 09 '24 11:07 mareklibra

Unnecessary Changesets

The following package(s) are private and do not need a changeset:

  • @backstage-community/plugin-orchestrator-swf-editor-envelope

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-orchestrator-backend workspaces/orchestrator/plugins/orchestrator-backend patch v1.13.1
@backstage-community/plugin-orchestrator-common workspaces/orchestrator/plugins/orchestrator-common patch v1.10.0
@backstage-community/plugin-orchestrator-swf-editor-envelope workspaces/orchestrator/plugins/orchestrator-swf-editor-envelope patch v1.0.0
@backstage-community/plugin-orchestrator workspaces/orchestrator/plugins/orchestrator patch v1.16.0

backstage-goalie[bot] avatar Jul 09 '24 11:07 backstage-goalie[bot]

Hey @mareklibra, I managed to get a green CI on this with some follow-up commits in https://github.com/backstage/community-plugins/pull/712#commits-pushed-2e3ce93 that could be cherry-picked. I tried to give the commits meaningful titles, but feel free to reach out on Discord/Slack if they're unclear.

I think this PR unfortunately hit two issues of which there are open backstage/backstage PRs to remediate:

  • https://github.com/backstage/backstage/pull/25671: Temporarily resolved by overriding the version of @microsoft/api-extractor
  • https://github.com/backstage/backstage/pull/25792: Temporarily resolved by dropping the --tsc from yarn api:reports

BethGriggs avatar Jul 25 '24 22:07 BethGriggs

Hi @BethGriggs and @mareklibra, what's the status of this one? Just trying to clean up some of the older PRs.

awanlin avatar Sep 08 '24 18:09 awanlin

Closing, it's outdated. A replacement will be drafted later on.

mareklibra avatar Sep 11 '24 12:09 mareklibra