community-plugins icon indicating copy to clipboard operation
community-plugins copied to clipboard

fix(jenkins): remove unused dependencies per knip report

Open Ayushmore1214 opened this issue 3 months ago • 5 comments

Hey, I just made a Pull Request!

This PR removes unused dependencies from the jenkins workspace as identified by the knip reports.

:heavy_check_mark: Checklist

  • [ ] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [ ] All your commits have a Signed-off-by line in the message. (more info)

Ayushmore1214 avatar Nov 17 '25 06:11 Ayushmore1214

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage-community/plugin-jenkins-backend
  • @backstage-community/plugin-jenkins
  • @backstage-community/plugin-scaffolder-backend-module-jenkins

See CONTRIBUTING.md for more information about how to add changesets.

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

  • /home/runner/work/community-plugins/community-plugins/.changeset/fruity-seals-play.md: @backstage-community/plugins

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
app-next workspaces/jenkins/packages/app-next none v0.0.2
app workspaces/jenkins/packages/app none v0.0.7
backend workspaces/jenkins/packages/backend none v0.0.11
@backstage-community/plugin-jenkins-backend workspaces/jenkins/plugins/jenkins-backend none v0.20.0
@backstage-community/plugin-jenkins workspaces/jenkins/plugins/jenkins none v0.25.0
@backstage-community/plugin-scaffolder-backend-module-jenkins workspaces/jenkins/plugins/scaffolder-backend-module-jenkins none v0.14.0

backstage-goalie[bot] avatar Nov 17 '25 06:11 backstage-goalie[bot]

@awanlin plz review , and we have to create a changeset for this right , on the way !

Ayushmore1214 avatar Nov 17 '25 06:11 Ayushmore1214

Hi @Ayushmore1214, reviewers get assigned automatically and will get notified, you don't need to ping them when a PR gets created. This just adds noise to their inbox. If you can avoid doing that it would be greatly appreciated 🙏

awanlin avatar Nov 17 '25 14:11 awanlin

@BethGriggs Can you let me know whether do I create a changeset for this !

Ayushmore1214 avatar Nov 25 '25 15:11 Ayushmore1214

The checks are failing it says to add the yarn.lock after running yarn install , but it doesn't shows any changed file to add after running yarn install , any recommendations to fix this ??

Ayushmore1214 avatar Nov 25 '25 15:11 Ayushmore1214

Following up for the review

Ayushmore1214 avatar Dec 05 '25 05:12 Ayushmore1214

I'm unsure why the yarn install is failing. This appears to be removing a lot of dependencies in one go, maybe try removing them incrementally?

BethGriggs avatar Dec 09 '25 11:12 BethGriggs