Feature/multi confulence support
Hey, I just made a Pull Request!
This PR adds the ability to index and search documentation from multiple Confluence instances in Backstage.
The backend collator factory and module are updated to dynamically register a collator for each configured Confluence instance. Documentation is updated with configuration examples and UI integration instructions.
How to use
->Add each Confluence instance under the confluence key in app-config.yaml (e.g., default, secondary). ->Register a collator for each instance under search.collators, using the instanceKey property. ->Update your search UI to include all Confluence types so users can search across all sources.
See the updated README for details and examples.
:heavy_check_mark: Checklist
Thanks for the contribution! All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.
Hi, @awanlin, one of the check is failing. can you look into this.
Hi @Kaushalendra-Singh-007, is there a reason you created a new PR? It's generally the proper practice to update your existing PR based on the review feedback. Creating new PRs creates a confusing process for everyone.
If you address the conflicts that should help get the CI running again 👍
Hi @awanlin , Thank you for your feedback! I apologize for any confusion caused by creating a new PR. I ran into some issues with resolving conflicts and thought starting fresh would be easier, but I understand now that updating the existing PR is preferred. I’ll make sure to address conflicts and keep updates within the same PR.
Thanks for your guidance!
Changed Packages
| Package Name | Package Path | Changeset Bump | Current Version |
|---|---|---|---|
| @backstage-community/plugin-search-backend-module-confluence-collator | workspaces/confluence/plugins/search-backend-module-confluence-collator | minor | v0.15.0 |
👋 I'm very much interested in this feature! It looks like this PR is missing some new functionality (caching) that was added in this PR. @Kaushalendra-Singh-007 would you be able to add that back in?
Hi @awanlin, can you look into this. All checks are passed. Let me know if anything else do we need to look.
Hi @Kaushalendra-Singh-007, I'm back from various travels and vacation, and doing some follow up, will you be able to address my last set of review comments?
Hi @awanlin @fjudith, Our team has been eagerly waiting for this PR to move forward, and we’re hoping to get it reviewed and accepted soon. We appreciate your time and support; this feature will really help us and other adopters.
Thank you for this great work @HK-9. I suggest to restore the documentation of the old configuration schema with deprecation notices. It also prevent the leak of confidential data.
Thanks @fjudith. I’ve applied these changes locally and pushed an updated commit that restores the legacy configuration documentation with deprecation notices and clarifies the rate-limiting behavior.
Thank you for this great work @HK-9. I suggest to restore the documentation of the old configuration schema with deprecation notices. It also prevent the leak of confidential data.
Thanks @fjudith. I’ve applied these changes locally and pushed an updated commit that restores the legacy configuration documentation with deprecation notices and clarifies the rate-limiting behavior.
Thanks a lot for the great work @Kaushalendra-Singh-007 and @HK-9 .
Could you please rebase your local branch the main ?
Usually this can be done like this
git remote add upstream https://github.com/backstage/community-plugins
git pull upstream main --rebase
@Kaushalendra-Singh-007 and @HK-9 just discovered that Github let's me fix the branch drif .
We're all set. Thanks again for your contribution ❤️