community-plugins icon indicating copy to clipboard operation
community-plugins copied to clipboard

[WIP] Starting point for matrix version bump

Open awanlin opened this issue 1 year ago • 3 comments

Hey, I just made a Pull Request!

This adds a version bump workflow using the workspaces as a matrix.

Note: The core code has been used in the Backstage Demo repo for a long time now, this essentially copies that code over and adjusts it to work in a matrix.

:heavy_check_mark: Checklist

  • [ ] A changeset describing the change and affected packages. (more info)
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

awanlin avatar May 17 '24 20:05 awanlin

I haven't looked into the code yet. Does this introduce an implicit expectation on all plugin maintainers that their plugins will update to the new Backstage release at the same time [when this workflow runs]?

BethGriggs avatar May 20 '24 12:05 BethGriggs

I haven't looked into the code yet. Does this introduce an implicit expectation on all plugin maintainers that their plugins will update to the new Backstage release at the same time [when this workflow runs]?

This would create a PR that the Owner then chooses to merge or not, I see it like the Renovate PRs. But your comment does make me think if we should make this as more "opt-in" vs "everyone gets a PR" 🤔

awanlin avatar May 20 '24 13:05 awanlin

No concerns here with seeing how it goes with having this on by default, at first.

As follow up question: I suppose not all of these Backstage bump PRs are expected to pass CI every time as the plugin may require changes based on new backstage release? In that case, would we expect the plugin maintainer to push the necessary updates to the same PR? I could see that being a nice approach but I think we would need to provide guidance.

BethGriggs avatar May 21 '24 21:05 BethGriggs

This is ready for review. Currently is setup to run a single workspace in a matrix. This will allow me to test it more easily. I'd like to get this merged as is to start and then in a follow up PR I can expand it to work with more workspaces and consider scheduling it.

awanlin avatar Jun 07 '24 22:06 awanlin

@benjdlambert just a ping so this gets in your inbox to look at, please. 😄

awanlin avatar Jun 18 '24 14:06 awanlin

Let's give it a go!

benjdlambert avatar Jun 18 '24 15:06 benjdlambert

Looks like I need one more @BethGriggs or @vinzscam any chance you could give this a review please?

awanlin avatar Jun 18 '24 16:06 awanlin

Thanks @BethGriggs @benjdlambert 🚀

awanlin avatar Jun 19 '24 11:06 awanlin