fix(search-backend-module-confluence-collator): refine CQL query generation for spaces and query

[dfl-aeb]

Hey, I just made a Pull Request!

Fixes #4016

Previously, the Confluence collator would generate an invalid CQL query of the form () and (label="test") if the spaces configuration was empty or not provided, but a query was specified. This resulted in no search results.

This commit refines the CQL query generation logic to correctly handle different combinations of spaces and query parameters:

• If only spaces are provided, the query will be space=S1 or space=S2.
• If only query is provided, the query will be your_query_here.
• If both spaces and query are provided, they will be combined as (space="S1" or space="S2") and (your_query_here).
• If neither is provided, the default query to fetch all content types (type IN (page, blogpost, comment, attachment)) is used.

Additionally, new test cases have been added to cover these scenarios, and the plugin documentation has been updated to clarify the behavior of these parameters.

:heavy_check_mark: Checklist

• [x] A changeset describing the change and affected packages. (more info)
• [x] Added or updated documentation
• [x] Tests for new functionality and regression tests for bug fixes
• [ ] Screenshots attached (for UI changes)
• [x] All your commits have a Signed-off-by line in the message. (more info)

[backstage-goalie[bot]]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage-community/plugin-search-backend-module-confluence-collator	workspaces/confluence/plugins/search-backend-module-confluence-collator	patch	v0.10.0

[github-actions[bot]]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[dfl-aeb]

Hey @vinzscam or @fjudith,

could you have a look at this pr? It's only a small fix, but it would help us start using the plugin.

[dfl-aeb]

@vinzscam friendly reminder.

[dfl-aeb]

@vinzscam I had to rebase. Could you please approve again and merge it?

[fjudith]

@vinzscam the Github workflow seems to be stuck. Any idea on how to resolve the issue ?

[dfl-aeb]

@vinzscam friendly Reminder

[dfl-aeb]

Can you help out here, @fjudith? I don't understand what still needs to be done.

I guess @vinzscam needs to approve the last pending workflow and then merge it?

[fjudith]

Hello @awanlin and @vinzscam !

Could you please help us int getting this PR merged ?

[github-actions[bot]]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

[dfl-aeb]

Not stale, we're so close ... @vinzscam @awanlin

[dfl-aeb]

@stanley-nicholl thanks for the approval. What needs to be done to get it merged?

[stanley-nicholl]

@dfl-aeb, just needs an official maintainer approval. Should be merged by today or tomorrow. Thanks for doing this!!