community-plugins
community-plugins copied to clipboard
🐛 Bug Report: ADR plugin failed to render the image
📜 Description
I'm encountering a "Bad Request (400)" error when attempting to display an image from GitHub.
"@backstage-community/plugin-adr": "^0.8.0",
"@backstage-community/plugin-adr-backend": "^0.6.0",
👍 Expected behavior
image will be rendered and show up in Backstage ADR.
👎 Actual Behavior with Screenshots
the image is broken.
👟 Reproduction steps
- Install ADR plugin.
- add ADR MD file with attachment
- open the ADR
📃 Provide the context for the Bug.
No response
🖥️ Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?
- [x] I checked and didn't find similar issue
🏢 Have you read the Code of Conduct?
- [x] I have read the Code of Conduct
Are you willing to submit PR?
None
cc @kuangp 🙏
hi @yoramshai it looks like the linked image url is not one that is currently supported - the plugin requires a direct url to a image file that typically ends in one of these supported file type extensions. GitHub user attachment asset urls looks to be proxy urls to actual file locations
Will GitHub attachments be supported? Since we are dealing here with GitHub markdown files, snapshots as attachments are a common use case.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@yoramshai, it may be worth opening as new issue as a feature request for the plugin
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.