🐛 Confluence: API Request Fails When Spaces Array is Empty

[eiriksanderfjeld]

Plugin Name

search-backend-module-confluence-collator

📜 Description

The search-backend-module-confluence-collator plugin encounters an issue where the API request fails if the spaces array is empty and the query parameter is non-empty. This issue occurs in the getDocuments method of the ConfluenceCollatorFactory.ts file.

👍 Expected behavior

The plugin should handle the case where the spaces array is empty and the query parameter is non-empty, constructing a valid query that does not cause the API request to fail.

👎 Actual Behavior with Screenshots

When the spaces array is empty and the query parameter is non-empty, the constructed query is invalid, leading to a failed API request.

👟 Reproduction steps

I have installed the latest version of the confluences plugins, and are authenticating with token. When spaces are empty, the query will fail with an non-ok response from Confluence.

📃 Provide the context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

• [X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• [X] I have read the Code of Conduct

Are you willing to submit PR?

No, but I'm happy to collaborate on a PR with someone else

[fjudith]

Thank you for reporting this bug @eiriksanderfjeld .

I'm taking the resolution of this bug.

[benjidotsh]

Any update on this? @fjudith

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.