community-plugins icon indicating copy to clipboard operation
community-plugins copied to clipboard

🔧 Repository: Failed to Generate Version Packages PR

Open awanlin opened this issue 1 year ago • 4 comments
trafficstars

📜 Description

While upgrading various plugins to 1.30.2 after merging the version bump PR the Version Packages PR was not created for several plugins. I had not noticed the issue until I had already merged several version bump PRs already.

The following workspaces need to have a Version Packages PR create so that the changes get released:

  1. azure-storage-explorer
  2. bazaar
  3. confluence
  4. explore
  5. fossa
  6. github-actions
  7. gocd
  8. grafana
  9. graphql-voyager
  10. playlist

The follow have been released since this issue was first logged:

  1. 3scale
  2. adr
  3. airbrake
  4. allure
  5. apache-airflow
  6. apollo-explorer
  7. azure-sites
  8. bitrise
  9. cloudbuild
  10. code-climate
  11. codescene
  12. entity-feedback
  13. entity-validation
  14. firehydrant
  15. fossa
  16. gcalendar
  17. gcp-projects
  18. git-release-manager
  19. github-deployments
  20. github-issues
  21. github-pull-requests-board
  22. gitops-profiles
  23. splunk
  24. vault

👍 Expected behavior

Version Packages PR should have been created.

👎 Current Behavior

Version Packages PR was not created and we see this error in the workflow:

/usr/bin/git checkout changesets-release/confluence
error: pathspec 'changesets-release/confluence' did not match any file(s) known to git
/usr/bin/git checkout -b changesets-release/confluence
Switched to a new branch 'changesets-release/confluence'
/usr/bin/git reset --hard 2fe1552213f0e43c0770b721f71b503ae0690d99
fatal: Could not parse object '2fe1552213f0e43c0770b721f71b503ae0690d99'.
Error: The process '/usr/bin/git' failed with exit code 1[28](https://github.com/backstage/community-plugins/actions/runs/10539739181/job/29203637609#step:9:29)
    at m._setResult (/home/runner/work/_actions/backstage/changesets-action/291bfc1f76d1dcfbf967f5810dc0423592eae09a/dist/index.js:102:7258)
    at m.CheckComplete (/home/runner/work/_actions/backstage/changesets-action/[29](https://github.com/backstage/community-plugins/actions/runs/10539739181/job/29203637609#step:9:30)1bfc1f76d1dcfbf967f5810dc0423592eae09a/dist/index.js:102:6686)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/backstage/changesets-action/291bfc1f76d1dcfbf967f5810dc0423592eae09a/dist/index.js:102:5723)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:[30](https://github.com/backstage/community-plugins/actions/runs/10539739181/job/29203637609#step:9:31)5:5)

👟 Reproduction steps

Honestly not sure exactly how this happens. I think if you merge several PRs at once then it will cause this to happen but I'm just guessing at the moment.

📃 Provide the context for the Bug.

N/A

👀 Have you spent some time to check if this bug has been raised before?

  • [X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

No, but I'm happy to collaborate on a PR with someone else

awanlin avatar Aug 24 '24 22:08 awanlin

When I merged this PR - https://github.com/backstage/community-plugins/pull/642 - for entity-validate it created the Version Packages PR - https://github.com/backstage/community-plugins/pull/1051 - and it included the version bump changes 👍

awanlin avatar Aug 26 '24 11:08 awanlin

3scale had it's Version Packages PR created - https://github.com/backstage/community-plugins/pull/1052 - as there was a Renovate PR to update some of its dependencies.

awanlin avatar Aug 26 '24 11:08 awanlin

The issue seems to be a mismatch between the HEAD sha of the ref at https://github.com/backstage/community-plugins/blob/1ac989eeb33f69578a9f55e5568bd3496cc25575/.github/workflows/release_workspace.yml#L54

and the sha that the backstage/changesets-action action ends up using.

For example, in the following failed run: https://github.com/backstage/community-plugins/actions/runs/10539750276/job/29203660661, the checkout action is checking out https://github.com/backstage/community-plugins/commit/588887c0f4869335428b22f402061ad68848d74a, but the changesets-action is trying to create a branch from https://github.com/backstage/community-plugins/commit/d5c3ebfaa90628f98f471d275f4b0b041bf32590, which seems to be the correct one.

CC @BethGriggs since I saw you made some changes in the area

Rugvip avatar Aug 27 '24 15:08 Rugvip

Reopening, we do have a fix but I'd like to use this to track the workspaces that haven't been published yet.

awanlin avatar Aug 28 '24 12:08 awanlin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 27 '24 18:10 github-actions[bot]

Sorry for the slow follow up all of the impacted plugins have been released

awanlin avatar Oct 31 '24 15:10 awanlin