charts icon indicating copy to clipboard operation
charts copied to clipboard

fix: service account namespace quote

Open ramonPires opened this issue 1 year ago • 5 comments

Description of the change

Fixed by adding a quote in the namespace value from the service account manifest, like in the other manifests in the project. OBS: helm-docs automatically changed the values from values.schema.json after running the pre-commit hook.

Existing or Associated Issue(s)

Additional Information

Checklist

  • [X] Chart version bumped in Chart.yaml according to semver.
  • [ ] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • [ ] JSON Schema generated.
  • [ ] List tests pass for Chart using the Chart Testing tool and the ct lint command.

ramonPires avatar Apr 26 '24 11:04 ramonPires

@ramonPires You'll need to resolve the DCO check, but thanks for the PR! It seems the pre-commit hook may have been missed by someone hence why it is getting updated!

ChrisJBurns avatar May 04 '24 12:05 ChrisJBurns

@vinzscam Wondering if you've seen the Error: Failed to instantiate service 'core.httpRouter' for 'app' because the factory function threw an error, Error: Failed to instantiate service 'core.auth' for 'app' because the factory function threw an error, Error: Failed to instantiate service 'core.tokenManager' for 'app' because the factory function threw an error, Error: Failed to instantiate service 'core.tokenManager' because createRootContext threw an error, Error: You must configure at least one key in backend.auth.keys for production. before? As far as I'm aware we don't set this value in our tests. Could there have been a change in the base backstage image that we use that now requires it? This is also happening on https://github.com/backstage/charts/pull/178 it seems.

ChrisJBurns avatar May 04 '24 13:05 ChrisJBurns

@vinzscam Never mind, just seen @sabre1041 's comment. @ramonPires I shall raise an issue to resolve this and get back to you (hopefully we can resolve the tests so you can merge this ASAP)

ChrisJBurns avatar May 04 '24 13:05 ChrisJBurns

@ramonPires Give this PR a rebase and you should be able to see only your changes in the diff. Also, just remember to bump the version again as its changed to 1.9.3 already

ChrisJBurns avatar May 11 '24 12:05 ChrisJBurns

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar May 19 '24 06:05 github-actions[bot]