backstage icon indicating copy to clipboard operation
backstage copied to clipboard

fix: schema collection for multiple backends

Open aramissennyeydd opened this issue 11 months ago • 8 comments

Hey, I just made a Pull Request!

Fixes #23655.

I'm definitely missing context on why we're doing this for the config in the first place. This change may not be needed.

This drops time to compile the schemas for backend-next on my M3 from 700ms to 400ms.

:heavy_check_mark: Checklist

  • [x] A changeset describing the change and affected packages. (more info)
  • [ ] Added or updated documentation
  • [ ] Tests for new functionality and regression tests for bug fixes
  • [ ] Screenshots attached (for UI changes)
  • [x] All your commits have a Signed-off-by line in the message. (more info)

aramissennyeydd avatar Mar 17 '24 19:03 aramissennyeydd

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage/backend-defaults
  • @backstage/config-loader

See CONTRIBUTING.md for more information about how to add changesets.

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

  • /home/runner/work/backstage/backstage/.changeset/clever-dodos-grow.md: @backstage/backend-app-api

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/backend-defaults packages/backend-defaults none v0.3.4-next.1
@backstage/config-loader packages/config-loader none v1.8.1

backstage-goalie[bot] avatar Mar 17 '24 19:03 backstage-goalie[bot]

Uffizzi Ephemeral Environment - Virtual Cluster

Your cluster pr-23661 was successfully created. Learn more about Uffizzi virtual clusters To connect to this cluster, follow these steps:

  1. Download and install the Uffizzi CLI from https://docs.uffizzi.com/install
  2. Login to Uffizzi, then select the backstage account and project:
uffizzi login
Select an account: 
  ‣ backstage
    jdoe

Select a project or create a new project: 
  ‣ backstage-6783521
  1. Update your kubeconfig: uffizzi cluster update-kubeconfig pr-23661 --kubeconfig=[PATH_TO_KUBECONFIG] After updating your kubeconfig, you can manage your cluster with kubectl, kustomize, helm, and other tools that use kubeconfig files: kubectl get namespace --kubeconfig [PATH_TO_KUBECONFIG]

Access the backstage endpoint at https://backstage-default-pr-23661-c5226.uclusters.app.uffizzi.com

github-actions[bot] avatar Mar 17 '24 19:03 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Mar 25 '24 09:03 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Apr 01 '24 13:04 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Apr 08 '24 14:04 github-actions[bot]

ping @aramissennyeydd :)

freben avatar Apr 08 '24 15:04 freben

@freben Waiting for feedback to my comment here - require.resolve is having some issues with relative resolution in tests that I think it would run into generally as well.

aramissennyeydd avatar May 06 '24 12:05 aramissennyeydd

👋 This should be ready for a re-review!

aramissennyeydd avatar May 13 '24 14:05 aramissennyeydd

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar May 29 '24 09:05 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Jun 12 '24 14:06 github-actions[bot]

bump

aramissennyeydd avatar Jun 12 '24 16:06 aramissennyeydd

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Jun 26 '24 16:06 github-actions[bot]

Not stale, this is waiting for a rereview

aramissennyeydd avatar Jul 03 '24 17:07 aramissennyeydd

FYI I happened to note there's a conflict.

freben avatar Jul 03 '24 17:07 freben

@freben I'll take a look at that tonight.

aramissennyeydd avatar Jul 03 '24 17:07 aramissennyeydd

@freben This should be ready now! 🌬️ merge conflict.

aramissennyeydd avatar Jul 07 '24 22:07 aramissennyeydd

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Jul 30 '24 13:07 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Aug 20 '24 10:08 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Sep 04 '24 06:09 github-actions[bot]

@Rugvip i guess.

freben avatar Sep 04 '24 07:09 freben

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions[bot] avatar Sep 20 '24 10:09 github-actions[bot]