actions icon indicating copy to clipboard operation
actions copied to clipboard

[changeset-feedback] Private packages are ignored, regardless of `.changeset/config.json`

Open lachieh opened this issue 1 year ago • 0 comments

Hey, first of all, thanks for this! We're using it over at wasmCloud/typescript repo. It's much less aggressive than the changeset bot 😅

Only feature I'd like to request is to respect the version private packages setting from the .changeset/config.json. We currently have an app which is not published to npm, but it does need versioning and its own release process.

'm happy to submit a PR for this—I was thinking I'd just load the config json and skip this condition:

https://github.com/backstage/actions/blob/b3c1841fd69e1658ac631afafd0fb140a2309024/changeset-feedback/generateFeedback.ts#L236-L238

lachieh avatar Jan 17 '25 04:01 lachieh