[UX] Update wizard titles are inconsistent (and can be confusing)

[jenlampton]

Description of the bug

This is a follow-up to https://github.com/backdrop/backdrop-issues/issues/6805 which is a follow-up to https://github.com/backdrop/backdrop-issues/issues/2409

Steps To Reproduce

Run site updates, step through each step of the wizard.

Expected behavior

I would expect that the "page title" (or heading) on the modal would update to match the progress indicated down the left sidebar.

Recommendation

I wasn't fast enough to get a screenshot of "Updating..."

Additional information

Backdrop CMS: 1.30.x-dev Installation profile: standard PHP version: 8.1.30 Drupal 7 compatibility: on Database server: 10.4.34-MariaDB-1:10.4.34+maria~ubu2004-log Web server: nginx/1.26.2

[jenlampton]

I'm not sure how I feel about having "Update Backdrop CMS" in each title, but without "Update" it's not entirely clear what the wizard is doing, and without "Backdrop CMS" you don;t really know you are updating -- do either of these things matter? I dunno!

[stpaultim]

@yorkshire-pudding, @cellear and I just reviewed this issue after the dev meeting.

In general, we like this change but have a few small questions/suggestions:

1. In this case, we're updating Ubercart, not Backdrop CMS. So we are thinking that maybe it should just read "Update: Overview". On all pages, change "Update Backdrop CMS" to "Update"?

2. "Review" does not match "Review Log" in left column. We understand that if successful, there is no log on this page. Maybe we should remove the word "Log" from left column. Any thoughts?

Otherwise this PR looks good.

[stpaultim]

Since the only way to test this PR is to install an OLD module and run the update process, I've included screenshots of the current pages to compare with those listed in the original post by @jenlampton.

This is BEFORE the PR.

AFTER PR screenshots are available above.

[bugfolder]

Since the only way to test this PR is to install an OLD module and run the update process,

Or if you're comfortable with editing the db directly (and the actions taken by a module's update are relatively innocuous, like setting a new config variable), in the system table, edit the schema_version of the module to decrement its value by 1, to make the system think the update hadn't yet been run.

Of course, if the update isn't innocuous—like adding or dropping a db column—then that is not a good way to test the update!

[izmeez]

Consider this. The Wizard title is a simple sentence: Update Backdrop CMS Overview/Review.

It has an action, an object and an output. All three components are important.

What we need is a way to change the object name and retain the context: Backdrop CMS, Ubercart, CiviCRM, etc. Maybe this is in the form api title?

[stpaultim]

What we need is a way to change the object name and retain the context: Backdrop CMS, Ubercart, CiviCRM, etc. Maybe this is in the form api title?

This feels a bit overcomplicated, don't you think?

In this case we were just upgrading Ubercart, but in some cases you might be updating core and several modules at once. I don't think we need to be that specific in the title. Maybe, just more generic.

[yorkshire-pudding]

What we need is a way to change the object name and retain the context: Backdrop CMS, Ubercart, CiviCRM, etc. Maybe this is in the form api title?

This feels a bit overcomplicated, don't you think?

In this case we were just upgrading Ubercart, but in some cases you might be updating core and several modules at once. I don't think we need to be that specific in the title. Maybe, just more generic.

Agree, this would get wordy if updating multiple things at once - think about the site where updates have been neglected for a while and there are a lot. Or even if you wait until the Backdrop minor releases before updating all modules and Backdrop.