backdrop-issues icon indicating copy to clipboard operation
backdrop-issues copied to clipboard

PHP date formats page has moved, update links in description

Open jenlampton opened this issue 11 months ago • 1 comments

Description of the bug

There are a few places where we link to the date formats page for PHP, but it's changed.

Old link destination: https://www.php.net/manual/en/function.date.php Recommended new link: https://www.php.net/manual/en/datetime.formats.php#datetime.formats.time

Steps To Reproduce

To reproduce the behavior:

  1. Go to recent log messages at admin/config/development/logging
  2. Click on PHP manual(link is external)
  3. Find nothing useful about how to format your date

This probably needs to be upated on the date formats page as well, and anywhere else we may have had the old link in the code.

Additional information

Add any other information that could help, such as:

  • Backdrop CMS version:
  • Web server and its version:
  • PHP version:
  • Database sever (MySQL or MariaDB?) and its version:
  • Operating System and its version:
  • Browser(s) and their versions:

jenlampton avatar Jan 08 '25 06:01 jenlampton

@jenlampton I belief, this has already been fixed in https://github.com/backdrop/backdrop-issues/issues/4536 (several years ago).

I can't find any url like php.net/manual/en/function.date.php throughout core, so I don't know where your own install should get them from, if not hopelessly outdated (older than 1.16.3).

indigoxela avatar Jan 08 '25 16:01 indigoxela

I made a PR to update these links.

The main one was as @jenlampton mentioned:

Image

But there were some others I found and updated too.

NormPlum avatar Oct 28 '25 05:10 NormPlum

Many thanks for picking this issue up and digging through code. 👍

I can confirm that the PR fixes/improves several links (some were a bit tricky to find in admin UI 😉). As this is a help text only change, I'm going ahead and mark it as RTBC. 👍

indigoxela avatar Oct 28 '25 07:10 indigoxela

Thanks @NormPlum, @indigoxela, and @jenlampton -- merged into 1.x and 1.32.x.

laryn avatar Oct 28 '25 13:10 laryn