backdrop
Switching the node_admin_theme option should flush the layout cache but doesn't
Description of the bug
It's a rather subtle problem, as the default admin theme and the default theme aren't that different. But it's visible. Even more if the layouts do differ significantly.
Steps To Reproduce
- Switch the setting "Use the administration theme when editing or creating content" off and save on admin/appearance
- Open a node form, like node/add/post
- Inspect the current layout via admin bar dropdown "This page"
- Switch the setting "Use the administration theme when editing or creating content" back on and save (do not flush caches manually)
- Open a node form
- Inspect the current layout via admin bar
Actual behavior
When the default theme is selected for node edit/create, the Default Layout should be in use. When the admin theme is selected, the Default Administrative Layout should be used. But switching doesn't change that, so the wrong Layout is used, until one flushes caches.
This leads to visual glitches. I've seen this before, but didn't actually realize the source of the glitch.
^^ That's a harmless example, it can look a lot weirder, depending on layout adaptions (blocks).
Expected behavior
The right layout after switching.
Additional information
- Backdrop CMS version: latest dev, not sure when this problem started
A PR is available for testing and review.
I tried to narrow the flush down to specific items, but all the node/add/NODETYPE have their own entry, and that's potentially a lot. Flushing is easier.
I spun up a fresh site at backdropcms.org and tried the steps you describe and cannot replicate the problem you describe.
I spun up a fresh site at backdropcms.org and tried the steps you describe and cannot replicate the problem you describe.
It's essential to follow the exact steps, in order to put the old value into the cache_layout_path table.
That cached, but outdated value will then be used to apply the layout to node/add/THETYPE - the wrong layout.
The visual glitch can be subtle, but with the "This page" dropdown you can verify that the wrong layout's in use.
@indigoxela I made a suggestion in the PR to use Layout module's dedicated cache clear function, in the event that other caches are in place (or are in the future). The admin theme setting is so tightly tied to the default admin layout that I think this is a reasonable thing to do.
I made a suggestion in the PR to use Layout module's dedicated cache clear function
Merging wasn't such a good idea... :laughing: Syntax error. There was a semicolon missing in your commit. I'll fix it, and rebase.
Done, merged-fixed-rebased. Do we need another round of testing? Or is it still RTBC?
There was a semicolon missing in your commit. I'll fix it, and rebase.
That's why we have testing :joy: Thanks for fixing that. With the parent function doing the exact same thing as before (plus additional cache clearing) this looks good to me. I'll get it on my next pass through RTBC issues.
Thanks @indigoxela, @izmeez, and @argiepiano! I merged https://github.com/backdrop/backdrop/pull/4639 into 1.x and 1.27.x.