backdrop-issues icon indicating copy to clipboard operation
backdrop-issues copied to clipboard

breadcrumb adds page title as "last" crumb when there are no crumbs

Open jenlampton opened this issue 6 years ago • 5 comments

Description of the bug When I check the option Display the current page title as the last breadcrumb and have the breadcrumb block on them home page (when the home page is using the default layout, for example) the page title prints in the breadcrumb area, even though there are no breadcrumbs.

Steps To Reproduce To reproduce the behavior:

  1. Switch home page to use default layout (or disable home page layout)
  2. Configure breadcrumb block on default layout: check the option Display the current page title as the last breadcrumb
  3. Visit the home page

Actual behavior The page title prints in the breadcrumb area, even though there are no breadcrumbs. breadcrumb

Expected behavior I would expect that when there are no crumbs, there is no page title.

jenlampton avatar Aug 01 '19 20:08 jenlampton

This seemed fairly simple, so I made a PR: https://github.com/backdrop/backdrop/pull/4958

NormPlum avatar Dec 28 '24 11:12 NormPlum

I left a comment in the PR.

avpaderno avatar Dec 29 '24 09:12 avpaderno

Can we update the steps to reproduce, just to verify if the problem has changed since this ticket was written.

If I do the steps to reproduce exactly as written (I chose to disable home page layout), I get this:

image

Steps To Reproduce
To reproduce the behavior:

* Switch home page to use default layout (or disable home page layout)
* Configure breadcrumb block on default layout: check the option Display the current page title as the last breadcrumb
* Visit the home page

Otherwise, how does one switch home page to use default layout?

stpaultim avatar Dec 30 '24 22:12 stpaultim

After disabling the homepage layout I set a new homepage via Site Information (so you get something other than a Page Not Found).

NormPlum avatar Dec 31 '24 01:12 NormPlum

@NormPlum Thanks, that was helpful.

I've tested the PR and compared it to a site without the PR and I believe that this does fix the problem. I'll give it a WFM.

stpaultim avatar Jan 02 '25 00:01 stpaultim