backdrop-issues
backdrop-issues copied to clipboard
backdrop
crossport views commits from 7.x-3.12
- [x] https://github.com/backdrop/backdrop/pull/2674 | d55db813 | Issue #2480753 by dawehner, jibran, das-peter: Make it easier to subclass views_handler_area_view
- [x] https://github.com/backdrop/backdrop/pull/2673 | 4317c5eb | Issue #1831162 by dcmouyard, Valentine94: Tables generated by Views need better semantics
- [x] https://github.com/backdrop/backdrop/pull/2672 | d08465de | Issue #1976836 by Dean Reilly: Views locale edit link field uses the old D6 path
- [x] https://github.com/backdrop/backdrop/pull/2671 | 4218722c | Issue #1959594 by chrisjlee: typo 'lenght' in view_trim_views()
- [x] https://github.com/backdrop/backdrop/pull/2670 | 39abeb04 | Issue #2473959 by fizk: Typo
- [x] https://github.com/backdrop/backdrop/pull/2669 | 2a5df673 | Issue #1819538 by azinck: More link disappears when time-based views cache is enabled
- [x] N/A | c3536f4d | Issue #1036962 by acbramley, dsnopek, grahamC, mr.york, das-peter, wiifm: Edit link destination incorrect when using AJAX-enabled views - Fixed in Backdrop in eff5173481b797f30c2a0a2ee01d1a46dafabb10
- [x] https://github.com/backdrop/backdrop/pull/2668 | c125e4fc | Issue #2408939 by shashikant_chauhan: Views Plugins documentation topic lists incorrect number of plugin types
- [x] https://github.com/backdrop/backdrop/pull/2667 | d7837bc1 | Issue #2284593 by jhedstrom, Lendude: Fatal error: Call to a member function ensure_my_table() on a non-object
- [x] N/A | 96a54e04 | Issue #1809958 by joelpittet, steve.stotter, alesr, klaasvw: Views with exposed filter (ajax enabled) inside modal window (ctools)
- [x] https://github.com/backdrop/backdrop/pull/2666 | ae60042d | Issue #2188165 by dww, jesss, tim.plunkett: Issue tag 'is/not empty' and 'not one of' operators do not work
- [x] https://github.com/backdrop/backdrop/pull/2665 | ea75e556 | Issue #1484208 by tedfordgif: Undefined index options_form()
- [x] https://github.com/backdrop/backdrop/pull/2664 | 28d92baa | Issue #2211253 by sandipmkhairnar: Incorrect array index given in example for hook_views_ajax_data_alter()
- [ ] https://github.com/backdrop/backdrop/pull/2661 | 05fcf52d | Issue #1802438 by andrewbelcher, vasike: get_result_entities() Doesn't support revisions
- [x] https://github.com/backdrop/backdrop/pull/2660 | 21fd8f9f | Issue #2115269 by lalweil, anrikun: Check for entity in views_handler_field_field->get_value() before accessing it.
- [x] https://github.com/backdrop/backdrop/pull/2659 | 24188c4f | Issue #339384 by colan: Added help text to keep the exposed filter terms list unset to keep unfiltered "Any" option default.
- [x] https://github.com/backdrop/backdrop/pull/2658 | 6d8b0cb5 | Issue #2376607 by rrfegade, dakku: Fix some typos in comments.
- [x] https://github.com/backdrop/backdrop/pull/2657 | 0f54f7fd | Issue #1491082 by drzraf, dawehner, colan: Set a default template if there is no theme definition.
- [x] https://github.com/backdrop/backdrop/pull/2656 | 4ae33535 | Issue #1771140 by imclean, das-peter, GuGuss: view_menu_alter() adding to existing "access arguments" causes user_access() error
- [x] https://github.com/backdrop/backdrop/pull/2655 | d66cd3e6 | Issue #1547924 by rbp: Document field_math feature previous value
- [x] N/A See https://github.com/backdrop/backdrop-issues/issues/4137 | fba32b8e | Issue #1248716 by milesw, ndf, stefan.r: Views strings not translatable when loaded from a feature
- [x] https://github.com/backdrop/backdrop/pull/2653 | 5a0309a2 | Issue #2559839 by hexabinaer: [Backport] Expand display "Comment" trim from 10 to 80 characters
- [x] https://github.com/backdrop/backdrop/pull/2652 | f510a924 | Issue #1940212 by jweowu: "Content translation: Translations" relationship incorrectly specifying translation source
- [x] N/A | 8e0dab36 | Issue #2579819 by skyredwang: Deprecating PHP4 style constructors
- [x] N/A | dd39988f | Issue #2450447: Drupal QA is broken for Views 7.x-3.x - Already fixed in Backdrop per eff5173481b797f30c2a0a2ee01d1a46dafabb10.
- [x] N/A (see #3775) | d649d329 | Issue #2204257 by ezra-g, andyg5000: Update Views Content access filter per core performance improvements https://github.com/backdrop/backdrop/pull/2651
- [x] https://github.com/backdrop/backdrop/pull/2679 see comment/question | 4edefe17 | Issue #1154830 by heddn, hass, dunix: Schema mismatch after upgrade D6 to D7
- [x] https://github.com/backdrop/backdrop/pull/2650 | 9aaf9692 | Issue #1337894 by fengtan: Views RSS feeds have validation issues
- [x] https://github.com/backdrop/backdrop/pull/2649 | 0ae5fd66 | Issue #1751424 by Ken Ficara, jwilson3: Undefined index: current_user
Re https://www.drupal.org/node/1154830 and the respective 7.x commit, do we support D6 straight to Backdrop, and in general, do we advise people to first upgrade to the latest version of the respective 7.x module before doing D7 to Backdrop upgrades?
I'm asking because the commit adds a
views_update_7302(), which would have already run if the module on a D6/D7 site was using the latest version of Views 7.x. Other wise, do we need to add a new 100x update hook on our end?
We seem to already have implemented the same fix as https://git.drupalcode.org/project/views/commit/96a54e041b171eb47c6a00805b9c4731c81d9283, but we are using form#views-exposed-form- instead of #views-exposed-form-. I called it a N/A, but feel free to change that if you thing that we should change things accordingly.
Re drupal.org/node/1154830 and the respective 7.x commit, do we support D6 straight to Backdrop,
No. Not officially, but I think there is an issue somewhere to add this. Though, the longer it takes to address that, the harder it will get.
and in general, do we advise people to first upgrade to the latest version of the respective 7.x module before doing D7 to Backdrop upgrades?
Yes.
I'm asking because the commit adds a views_update_7302(), which would have already run if the module on a D6/D7 site was using the latest version of Views 7.x. Other wise, do we need to add a new 100x update hook on our end?
@klonos that update would only have already been run if someone had added the views module to their D7 site after the update was added, but before before moving to Backdrop. What if they had already upgraded from D7 to Backdrop before that update was added to D7 views. Is there anything in there that their Backdrop site won't have?
For other updates like this, we add the update to Backdrop, but in the update we test if the change has been made already. If so, we do nothing. If not, we do the update. That way we account for all use-cases.
...What if they had already upgraded from D7 to Backdrop before that update was added to D7 views. Is there anything in there that their Backdrop site won't have?... That way we account for all use-cases.
Makes sense @jenlampton 👍 ...will add a PR for that change as well then.
Since most of these PRs are RTBC, I've changed the tags to get committer eyes on this. @klonos there are 2 of these PRs that still need work:
- https://github.com/backdrop/backdrop/pull/2661
- https://github.com/backdrop/backdrop/pull/2659
Re https://www.drupal.org/node/1154830 and the respective 7.x commit, do we support D6 straight to Backdrop, and in general, do we advise people to first upgrade to the latest version of the respective 7.x module before doing D7 to Backdrop upgrades?
Yes, we do encourage that. Though it seems as though this particular issue could slip through to some (few) Backdrop sites. Since Backdrop existed for ~3 years by the time that issue was committed, it's possible that some Backdrop sites were upgraded from D7 with that problem before it was fixed in Views. It's low impact overall, so I think merging the fix suggested in https://github.com/backdrop/backdrop/pull/2679 is a good idea.
I merged in all the ready items here for 1.14.1. There are now only 3 remaining items. https://github.com/backdrop/backdrop/pull/2654 should be separated out into a dedicated issue, as I don't think we'll need/want a direct port of that code from Drupal 7.
Im getting same problem Access denied You are here Home You are not authorized to access this page.
Php 7.2 MariaDB 104
I've created a follow-up issue at https://github.com/backdrop/backdrop-issues/issues/4137 and marked the item as NA in this list.
Pushed a fix to this PR too https://github.com/backdrop/backdrop/pull/2661.
As far as I can see there are only two PRs left on this list. Fingers crossed they get merged and this whole issue can be closed.
Just adding a note here that there's only one more PR to close this issue, but it needs steps to reproduce the bug, so that we can confirm that the bug is fixed in Backdrop.
Here's a usecase that came up in Drupal:
Because for a project we would like to integrate Megarows with workbench. A few of the views Workbench supplies are based on revisions.
It might be worthwhile looking at the revision views in workbench, and trying to recreate them in Backdrop.
I tried to see if I could discover any new functionality in Views after the final patch in https://github.com/backdrop/backdrop/pull/2661, and I was not successful. The code seems to make sense but I can't tell where it would have any effect. I tried assembling a view starting from a "Content Revisions" table and a view from the "Content" table and joining over to revisions, but in both cases I can't find anything that I couldn't do before.
Looking for an older views crossport, I stumbled about this list where 28 of 29 tasks are checked, which is great! There is only one unclear issue - see https://github.com/backdrop/backdrop-issues/issues/3720#issuecomment-1017945548. Can we set the unclear issue to N/A and proceed?
I couldn't bear to bump this issue yet again. With only https://github.com/backdrop/backdrop/pull/2661 remaining and no complaints against the code implementation, I went ahead and merged that last PR so we can close this issue.