[UX] Account settings: Registration and cancellation: Hide email verification checkbox when "Admins only" is selected.

[klonos]

This setting has a long description, which adds to the page "noise" and required scrolling (more obvious on tablet/mobile):

Let's hide it.

---

PR by @klonos: https://github.com/backdrop/backdrop/pull/2227

[stpaultim]

This seems like a simple, nice idea.

I created a new PR - so folks can try this out. https://github.com/backdrop/backdrop/pull/4621

Thanks @klonos for getting this started.

[olafgrabienski]

This seems like a simple, nice idea.

I created a new PR - so folks can try this out. https://github.com/backdrop/backdrop/pull/4621

Indeed a nice idea! Tested in the PR sandbox: As expected, the "Require email verification when a visitor creates an account" checkbox is there only shown if visitors are allowed to register accounts.

[stpaultim]

Does anyone else think this is a good enough idea to add to the bugfix milestone?

I think it would be nice to get at least one more person to review this idea and help us decide if we should push forward.

(Second PR from me is based upon earlier PR from @klonos and is more recent)

[avpaderno]

Since JavaScript is already used to hide settings when they do not apply (because a different setting), I think it makes sense to do the same on this form for the Require email verification setting.

[docwilmot]

Looks good to me, PR https://github.com/backdrop/backdrop/pull/4621 tested and looks good. RTBC to me.

[quicksketch]

Thanks folks! I have merged https://github.com/backdrop/backdrop/pull/4621 into 1.x and 1.27.x.

[klonos]

Sorry folks, didn't get a chance to review the PR that got merged and request this change to be made in time, but we should be indenting form elements that depend on others (since we got #5999). Here's a one-liner follow-up PR to do that: https://github.com/backdrop/backdrop/pull/4716

Here's a side-by-side before/after screenshot:

[quicksketch]

Thanks @klonos! I tested and merged your follow-up!