backdrop-issues
backdrop-issues copied to clipboard
backdrop
Drupal 7.44 to 7.50 commits: crossport or mark as NA.
- [x] | NA | 6b6bc1b | Issue #2678822 by DamienMcKenna, David_Rothstein, stefan.r: Drupal 7.43 regression: When an anonymous user submits a form with an un-uploaded file that leads to a validation error, the file is lost on the next correct submission
- [x] | https://github.com/backdrop/backdrop/pull/1461 | c273ce5 | Issue #2418209 by chintan.vyas, lucastockmann, jacob.embree: Replace user facing strings that use drupal.org as example of an external url
- [x] | https://github.com/backdrop/backdrop/pull/1460 | aa232a2 | Issue #2470145 by David_Rothstein, rbmboogie, tbradbury, johnpicozzi, talhaparacha, ifrik, darol100: Fix text for update manager checkbox for disabled extensions
- [x] | https://github.com/backdrop/backdrop/pull/1486 | a10a1cf | Issue #2640344 by rafaolf, mohit_aghera, GrigoriuNicolae, jhodgdon: Document how to make hook_search_info() titles translatable
- [x] | https://github.com/backdrop/backdrop/pull/1487 | c3bf748 | Issue #611294 by swentel, klausi, David_Rothstein, tsphethean, jenlampton, attiks, yched, sun, benjy, dcam: Added a new "administer fields" permission for trusted users to use the field UI.
- [x] | https://github.com/backdrop/backdrop/pull/1885 | https://github.com/backdrop/backdrop/pull/1466 | ebd9325 | Issue #2514136 by pwolanin, David_Rothstein, Fabianx, greggles: Add default clickjacking defense to core
- [x] | https://github.com/backdrop/backdrop/pull/1486 | a95cb56 | Issue #2395385 by DamienMcKenna: simpletest fatal error when creating a non language neutral node and not specifying a node body (this was actually N/A)
- [x] | https://github.com/backdrop/backdrop/issues/1474 | 65b71ab | Issue #2646280 by Elijah Lynn, pietmarcus: Remove IE pre-check and post-check Cache-control headers
- [x] | https://github.com/backdrop/backdrop/pull/1486 | 9bf8fdf | Issue #2712993 by MustangGB, klausi: Can't override the same CSS files multiple times
- [x] | N/A | 8472395 | Issue #2460833 by jackbravo, colinmccabe, checker, Alan D., twistor: _drupal_session_destroy() should return boolean
- [x] | https://github.com/backdrop/backdrop/pull/1486 | 1a7642e | Issue #2663746 by twistor, MustangGB: Array to string conversion in trigger.test for PHP 7
- [x] | N/A | d100499 | Issue #2663752 by twistor, DamienMcKenna, ParisLiakos, sdstyles, Berdir: Undefined string index 0 in DrupalTestCase::getAbsoluteUrl() in PHP 7
- [x] | https://github.com/backdrop/backdrop/pull/1486 | d51a63f | Issue #2718323 by Liam Morland, jhodgdon: In drupal_http_request(), mention http_build_query()
- [x] | https://github.com/backdrop/backdrop/pull/1486 | 33eab62 | Issue #2718179 by dagmar: Better documentation for suspicious encoded string in dblog tests
- [x] | 4536453 | Issue #2718323 by Liam Morland, jhodgdon: In drupal_http_request(), mention http_build_query()
- [x] | https://github.com/backdrop/backdrop/pull/1886 | d11d1c2 | Issue #376391 by mimran, snehi, pietmarcus, jhodgdon: Document that module_invoke_all / ModuleHandlerInterface::invokeAll reindexes arrays
- [x] | https://github.com/backdrop/backdrop/pull/1886 | c872c60 | Issue #2660240 by Kgaut: Typo in menu.inc
- [x] | https://github.com/backdrop/backdrop/pull/1886 | 1af0eb4 | Issue #2694731 by nicrodgers: user_access(): incorrect documentation
- [x] | N/A | 2647403 | Issue #2756209: Add the new Drupal 7 co-maintainers to MAINTAINERS.txt
- [x] | https://github.com/backdrop/backdrop/pull/1477 | 3a2b4f5 | Issue #2371861 by DuaelFr, YesCT, pietmarcus, Gábor Hojtsy, tucho: Strings including tokens in href or src attributes cannot be translated due to safeness check incompatibilities
- [x] | https://github.com/backdrop/backdrop/pull/1477| 3677ac5 | Issue #2371861 followup by David_Rothstein: Strings including tokens in href or src attributes cannot be translated due to safeness check incompatibilities
- [x] | N/A | a8c1ebd | Issue #2634840 by brianV: Add index on uid and module columns to authmap
- [x] | https://github.com/backdrop/backdrop/pull/1886 | b0fbd62 | Issue #2311305 by donutdan4114, stefan.r, Polonium, rpayanm, tadityar, Fabianx, Dave Reid: getPrefixInfo() calls wrong function to get the connection info
- [x] | https://github.com/backdrop/backdrop/pull/1886 | 09de859 | Issue #1364694 by gielfeldt: MemoryQueue::createItem does not return TRUE
- [x] | https://github.com/backdrop/backdrop/pull/1886 | 2503818 | Issue #2669568 by soaratul: Docblock typo in file_download_headers
- [ ] | https://github.com/backdrop/backdrop/pull/4461 | f7d2f47 | Issue #889772 by tuutti, stefan.r, opdavies, Sutharsan, Perignon, pjcdawkins, joachim, das-peter, YesCT, David_Rothstein, Zerdiox, hussainweb, Fabianx, mgifford, xjm: Following a password reset link while logged in leaves users unable to change their password
- [x] | N/A | d516757 | Issue #1713662 by nod_, Eric_A, treyhunner, sun, basvredeling: Introduce .editorconfig to auto-configure editors that support it
- [x] | https://github.com/backdrop/backdrop/pull/4462 | 1fea8c8 | Issue #2491353 by pfrenssen, pietmarcus, znerol, David_Rothstein: Cookies from previous tests are still present when a new test starts
- [x] | backdrop/backdrop#1443 | f0e660b | Issue #2551981 by jthorson, Mixologic, Fabianx, David_Rothstein: Add --directory option to run-tests.sh test discovery
- [x] | N/A | 8f7f28b | Issue #2189345 by benjy, sanduhrs, Mile23, joshtaylor, jbekker, David_Rothstein, klausi, sun, zaporylie, pfrenssen, jsacksick, jibran, Mixologic, znerol, Xano, alberto56: run-tests.sh should exit with a failure code if any tests failed
- [x] | https://github.com/backdrop/backdrop/pull/4460 | 7543eae | Issue #2364343 by damien_vancouver, criz, ksenzee, Neograph734, joegraduate, k_zoltan, droplet, pounard, jp.stacey, ciss, corbacho, TravisJohnston: Fix robots.txt to allow search engines access to CSS, JavaScript and image files
- [x] | N/A | 44e1b4f | Issue #2717633 by mikeytown2, twistor, scor, Fabianx, MustangGB: PHP 7 hook_rdf_mapping() ['mapping']['rdftype'] failing in rdf.test: RDF type is present on post
- [x] | N/A | 84539bd | Issue #412808 by Berdir, rupertj, beejeebus, sun, PieterDC, scottalan, catch: Handling of missing files and functions inside the registry
- [x] | N/A | 4d5d300 | Issue #2660754 by twistor, David_Rothstein: Invalid numeric comparison in OpenIDTestCase::testConversion()
- [x] | N/A | 4cdb4c5 | Add grouped entries for PHP 5.4 and 7 test failures to CHANGELOG.txt.
- [x] | N/A | b6939aa | Issue #2660766 by David_Rothstein, twistor: UpgradePathTaxonomyTestCase::testTaxonomyUpgrade() doesn't properly test field settings
- [x] | N/A | d833cb7 | Issue #2660762 by twistor: TrackerTest::testTrackerNewComments() sets the node title incorrectly
- [x] | https://github.com/backdrop/backdrop/pull/1888 | 0dcc87a | Issue #2633334 by orbmantell, e._s, catch, TravisCarden: Unsigned int vs. int mismatch between node.nid and history.nid
- [x] | NA | a1f2672 | Issue #2674028 by catch: Add page callback to admin/people/create menu item
- [x] | https://github.com/backdrop/backdrop/pull/1888 | 11dac6e | Issue #1732906 by peterpoe, Ken Ficara, forestgardener, eesquibel, minax.de: Uninitialized variable in number_field_formatter_settings_form
- [x] | N/A | df75f7c | Issue #2640888 by IRuslan, kala4ek: Broken link on image toolkits conf page when no toolkits are installed
- [x] | https://github.com/backdrop/backdrop/pull/1888 | 4fb5e50 | Issue #2669704 by eiriksm, jhodgdon: Missing function doc comments in user.pages.inc
- [x] | https://github.com/backdrop/backdrop/pull/1888 | 4f9fcc6 | Issue #2676472 by micaelamenara, dagmar, jhodgdon: docs for t() and related functions don't explain how context works
- [x] | https://github.com/backdrop/backdrop/pull/1888 | 3588007 | Issue #1622964 by felribeiro, snehi, ar-jan, Girish-jerk, jhodgdon, joachim, jp.stacey, stefan.r: docs for EntityFieldQuery::fieldCondition are really sparse
- [x] | N/A | 90cff29 | Issue #1388664 by akoepke, chirhotec, klokie, lOggOl: Blog module conflicts with other URL routes beginning with "blog/"
- [x] | https://github.com/backdrop/backdrop/pull/1888 | bc48446 | Issue #1327728 by Darren Oh, Josh Waihi, cspitzlay, c960657: ip_address() fails when client request IP and proxy IP are the same
- [x] | https://github.com/backdrop/backdrop/pull/1888 | 15da2e8 | Issue #2563751 by borisson_, rocketeerbkw, cilefen, pietmarcus, NikitaJain, imanol.eguskiza, pjonckiere: Password field errors on user create/edit/login when password is (literally) 0
- [x] | https://github.com/backdrop/backdrop/pull/1888 | 5009eff | Issue #2749489 by pwolanin: Write test for the User module security issue from SA-CORE-2016-002
- [x] | N/A | e06da1d | Issue #1116326 by s_leu, yannickoo, dawehner, nod_, pwolanin, David_Rothstein, ksenzee, realityloop, miro_dietiker, broeker, mariagwyn, Christian DeLoach: Support admin overlay in exposed forms
- [x] | https://github.com/backdrop/backdrop/pull/2001 | 5e71cae | Issue #2578173 by Peacog, David_Rothstein, maximpodorov, marvin_B8, andypost, alexpott, tatisilva: Increase menu title maxlength to 255 in forms containing menu items
- [x] | https://github.com/backdrop/backdrop/pull/2001 | 6c75ac1 | Issue #2393461 by David_Rothstein, mpv, maciej.zgadzaj, Sagar Ramgade, davic, Fabianx: format_xml_elements() does not allow unencoded values
- [x] | N/A | 86fc546 | Issue #2393461 followup by nevergone: format_xml_elements() does not allow unencoded values
- [x] | N/A | f68a354 | Issue #2393461 followup by Sagar Ramgade: format_xml_elements() does not allow unencoded values
- [x] | N/A | 206c7c1 | Issue #1081266 by stefan.r, jeroen.b, mikeytown2, David_Rothstein, tsphethean, mfb, joseph.olstad, marcelovani, Kars-T, joelpittet, Fabianx, catch, fgm, das-peter, alexpott, emcniece, oriol_e9g, sun, corbacho, klausi, mgifford, onelittleant, Peter Bex, Spleshka, beejeebus, Berdir, pwaterz, SocialNicheGuru, sylus, Wim Leers, heyyo, joshtaylor, swentel, alanburke, dagmar, alexmoreno, kenorb, EvanSchisler, Mark Theunissen, bmateus, andypost, Lukas von Blarer, ChristophWeber, nicholas.alipaz, arosboro, askibinski, dawehner, DerekL, ExTexan: Avoid re-scanning module directory when a filename or a module is missing
- [x] | https://github.com/backdrop/backdrop/pull/2001 | f68bbb9 | Issue #1458824 by idebr, JvE, therealssj, mayaz17, cwoky, Henrik Opel, lokapujya, kevinquillen, presleyd, nod_, jbeuckm, botris, mistermoper, gcardinal: Ajax doesn't work with Tableselect with checkboxes
- [x] | https://github.com/backdrop/backdrop/pull/2001 | 56940cd | Issue #1645156 by attiks, tstoeckler, talhaparacha, amontero, Carsten Müller, Albert Volkman, Gábor Hojtsy, David_Rothstein, leschekfm, vasi1186, dcam, catch, Sweetchuck, Fabianx, nicrodgers: URL generation only works on port 80
- [x] | https://github.com/backdrop/backdrop/pull/2001 | b042085 | Issue #2502263 by hgoto, David_Rothstein, klausi, ckng, rhclayto: Drupal 7.36 regression: hidden field textarea #default_value is ignored
- [x] | N/A | c759414 | Issue #2747679 by david_garcia, pashupathi nath gajawada, izaaksom: Ajax form callbacks can only be global functions
- [x] | https://github.com/backdrop/backdrop/pull/2001 | 3c6803f | Issue #2759899 by Fabianx: drupal_get_schema_versions() does report wrong data the first time a test is run
- [x] | https://github.com/backdrop/backdrop/pull/2001 | 6303a15 | Issue #2760609: Allow the use of callbacks instead of global functions in the Form API
- [x] | N/A | c371d42 | Add issue #2760609 and relevant change record to CHANGELOG.txt.
- [x] | N/A | bc60c92 | Issue #2488180 by stefan.r, stovak, pwolanin, David_Rothstein, Noe_, typhonius, KhaledBlah, joelpittet, Fabianx, geerlingguy, nithinkolekar, mikeytown2, jduhls, scuba_fly, travelvc, hass: Support full UTF-8 (emojis, Asian symbols, mathematical symbols) on MySQL and other database drivers when they are configured to allow it
- [x] | N/A | b2bf69c | Add change records to CHANGELOG.txt, and small wording changes.
- [x] | N/A | 5473c95 | Rearrange items in CHANGELOG.txt for Drupal 7.50 to be in a more logical order.
- [x] | N/A | 3705166 | Issue #2393461 CHANGELOG.txt entry should be for Drupal 7.50 (not Drupal 7.40).
- [x] | N/A | 4b96aef | Rearrange CHANGELOG.txt a bit more.
- [x] | N/A | d04427f | Various fixes to CHANGELOG.txt in preparation for Drupal 7.50.
- [x] | N/A | d2d2c5f | Issue #2761285 by MegaChriz: _drupal_session_write() does not always return a boolean
- [x] | N/A | ab6e1a0 | Fix typo in Drupal 7.50 CHANGELOG.txt.
- [x] | N/A | 78cba77 | Issue #2762393 by stefan.r, MustangGB, David_Rothstein: Skip error triggering for missing files if the files are empty or "default"
- [x] | N/A | 4d154b4 | Drupal 7.50
Separately:
- https://github.com/backdrop/backdrop-issues/issues/2844| b2bd3e0 | Issue #2215369 by fietserwin, Lowell, mondrake, mr.baileys, David_Rothstein, kristofferwiklund, TwoD, bradjones1, svanou, kristiaanvandeneynde, Fabianx: Various bugs with PHP 5.5 imagerotate(), including when incorrect color indices are passed in
git command:
git log 7.44..7.50 --reverse --no-merges --pretty=format:"- [ ] | #xx | [%h](http://drupalcode.org/project/drupal.git/commit/%H) | [%s](http://drupal.org/node/)"
REGEX: Find: (Issue #)(\w\w+)(.*?)(node\/) Replace: $1$2$3$4$2
Thanx for putting the list together @serundeputy. You beat me to it 😄
I'm still on vacation with my girls, so not much time, but I'll try my best to grab any low-hanging fruits and also review others' PRs. Note that my reviews should be considered only a second-pair-of-eyes look-through though.
I think this is NA for backdrop since files are auto-uploaded when we select them.
Yep, that is the case. Good call on setting this to NA. Thanx for double-checking on top just to be sure (was about to do that myself).
This issue is in 1.4.3 milestone. But 1.4.3 was released 17 days ago. @serundeputy maybe you mean 1.4.4 ?
@jenlampton looks like you guys have already started going though them. sprint++;
Moot; https://github.com/backdrop/backdrop/pull/1034/commits/977cfd7397862df9334784e4b190a35ab31f333b Thanks @jenlampton
This isn't actually moot, I did some work on that other D7 issue recently and realized that I missed one of the strings. Committed a new PR to address this same update at https://github.com/backdrop/backdrop/pull/1473
Yep @serundeputy I decided it was worth doing for myself anyway, good for me to know what went into 1.50 :)
All PRs that have been filed for this have either been merged or reviewed. We'll probably get 1.4.4 out tomorrow and continue any remaining items for the next bugfix release. Feature-items such as the new field permissions, X-Frame-Options, and the full UTF-8 database support will go into 1.5.0 (1.x) as we get them finished.
Returning to this issue.
New PR for the clickjacking issue: https://github.com/backdrop/backdrop/pull/1885 Change record ready: https://api.backdropcms.org/node/44961
...btw, I get "access denied" when trying to access unpublished change records on api.b.org. Can someone please fix that for me so that I can be able to review. Thanx in advance.
https://github.com/backdrop/backdrop/pull/1886 RTBC 👍 ...the php53 test failure is random; another manifestation of #2202
Left comments in https://github.com/backdrop/backdrop/pull/1887/files (drupal* -> backdrop*)
Thanks @klonos for the reviews. I've merged the ready ones. https://github.com/backdrop/backdrop/pull/1887 and https://github.com/backdrop/backdrop/pull/1888 need work.
Simple PR to address Drupal's 2364343: https://github.com/backdrop/backdrop/pull/1974 about robots.txt to allow css/js/images.
@jenlampton do you have the capacity to take a look at the 2 PRs mentioned by @quicksketch a couple of comments above? I have left some comments in them (mostly drupal to backdrop renames).
I pushed one last PR for these commits: https://github.com/backdrop/backdrop/pull/2001 The only one I couldn't immediately figure out is Various bugs with PHP 5.5 imagerotate(), including when incorrect color indices are passed in because we already made a bunch of changes to GD support in Backdrop. I was tempted to try to add the test and see if Backdrop has the same problems, but even the way the tests work is a little different. So, in the hopes to get as many of these in as possible I opened another issue were we can work on that separately: https://github.com/backdrop/backdrop-issues/issues/2844
The remaining two PRs, https://github.com/backdrop/backdrop/pull/1887 and https://github.com/backdrop/backdrop/pull/1888 have failing tests. Getting really close here!
I've merged https://github.com/backdrop/backdrop/pull/1885 (click jacking defense) into 1.x only, as this introduces a minor API difference. I updated the change record to reflect the version being 1.9.0.
And https://github.com/backdrop/backdrop/pull/1888 has now been merged as well! It had one failing test for which I pushed a final update. Merged into 1.x and 1.8.x.
Looks like that's the final one for this issue. Great job on completing these tough last ports! I'll be so happy to announce these ports complete during the next weekly meeting. :smile:
@quicksketch Looks like https://github.com/backdrop/backdrop/pull/1887 was missed and is still open/unmerged...
Based on @jenlampton's PR which I've closed, I've filed 3 separate PRs for the things we missed:
- https://github.com/backdrop/backdrop/pull/4460
- https://github.com/backdrop/backdrop/pull/4461
- https://github.com/backdrop/backdrop/pull/4462
I've updated the issue summary, and for visibility I removed the "fixed" label and changed the milestone to the next bug fix release.
Shoot, I hoped we could close out this issue, but there are some issues with https://github.com/backdrop/backdrop/pull/4461.
I did merge https://github.com/backdrop/backdrop/pull/4460 and https://github.com/backdrop/backdrop/pull/4462, which both looked good.
So we have just one lingering issue here. Maybe 1.28.2 :crossed_fingers:
The last issue in this was actually ported in a dedicated issue: https://github.com/backdrop/backdrop-issues/issues/6426 and was completed back in Backdrop 1.28.3. Yay, we can finally close this one.