backdrop-issues
backdrop-issues copied to clipboard
[UX] Change the page title for the detailed view of a log entry to "Log entry details"...
...or something that makes better sense. I know this is a very minor nit, but having it plain "Details" does not tell me anything by looking at the tab when I have multiple open in my browser.
I would even better like it if we were even more verbose and had the title include the log entry number. Like so: "Log entry 123 details"
...that would account for cases where one has multiple such entries pages opened in multiple tabs in their browser:
Agreed. Here's a PR: https://github.com/backdrop/backdrop/pull/3062
Page title of /admin/reports/event/40759
changed from 'Details' to 'Log message details (#40759)'.
'Log message #40759 details', or 'Details of log message #40759' looks better, isn't?
Has relevant test failure.
PR updated, tests passing.
Is 'title'
in hook_menu()
entries automatically being passed through t()
? I think so, but I just want to make sure.
Is 'title' in hook_menu() entries automatically being passed through t()?
Yes it is.
Thanks @indigoxela 🙏🏼 ...I should have checked myself really:
- "title callback": Function to generate the title; defaults to t(). If you require only the raw string to be output, set this to FALSE.
- "title arguments": Arguments to send to t() or your custom callback, with path component substitution as described above.
'Log message #40759 details', or 'Details of log message #40759' looks better, isn't?
I think that Log message #123 details
is better. (I actually think that we could drop the "details" bit).
PR updated:
Tested the PR.
Before:
After:
WFM (and a nice improvement!). Code reviewed, LGTM.
Thanks @klonos for filing this all those years ago, @BWPanda for the fix, and @bugfolder, @herbdool, @findlabnet, and @indigoxela for your review and inputs. Merged!