backdrop-issues icon indicating copy to clipboard operation
backdrop-issues copied to clipboard

[UX] Change the page title for the detailed view of a log entry to "Log entry details"...

Open klonos opened this issue 8 years ago • 9 comments

...or something that makes better sense. I know this is a very minor nit, but having it plain "Details" does not tell me anything by looking at the tab when I have multiple open in my browser.

I would even better like it if we were even more verbose and had the title include the log entry number. Like so: "Log entry 123 details"

...that would account for cases where one has multiple such entries pages opened in multiple tabs in their browser:

backdrop-log_entry_pages_opened_in_multiple_browser_tabs-title_details_for_all_of_them

klonos avatar Mar 03 '16 00:03 klonos

Agreed. Here's a PR: https://github.com/backdrop/backdrop/pull/3062

Page title of /admin/reports/event/40759 changed from 'Details' to 'Log message details (#40759)'.

ghost avatar Feb 03 '20 19:02 ghost

'Log message #40759 details', or 'Details of log message #40759' looks better, isn't?

findlabnet avatar Feb 03 '20 19:02 findlabnet

Has relevant test failure.

herbdool avatar Jun 07 '20 18:06 herbdool

PR updated, tests passing.

ghost avatar Feb 25 '22 00:02 ghost

Is 'title' in hook_menu() entries automatically being passed through t()? I think so, but I just want to make sure.

klonos avatar Feb 25 '22 13:02 klonos

Is 'title' in hook_menu() entries automatically being passed through t()?

Yes it is.

indigoxela avatar Feb 25 '22 13:02 indigoxela

Thanks @indigoxela 🙏🏼 ...I should have checked myself really:

  • "title callback": Function to generate the title; defaults to t(). If you require only the raw string to be output, set this to FALSE.
  • "title arguments": Arguments to send to t() or your custom callback, with path component substitution as described above.

klonos avatar Feb 25 '22 17:02 klonos

'Log message #40759 details', or 'Details of log message #40759' looks better, isn't?

I think that Log message #123 details is better. (I actually think that we could drop the "details" bit).

klonos avatar Feb 25 '22 17:02 klonos

PR updated:

image

ghost avatar Feb 26 '22 00:02 ghost

Tested the PR.

Before:

image

After:

image

WFM (and a nice improvement!). Code reviewed, LGTM.

bugfolder avatar Sep 21 '23 01:09 bugfolder

Thanks @klonos for filing this all those years ago, @BWPanda for the fix, and @bugfolder, @herbdool, @findlabnet, and @indigoxela for your review and inputs. Merged!

laryn avatar Oct 06 '23 11:10 laryn