babybuddy icon indicating copy to clipboard operation
babybuddy copied to clipboard

Release version 2.0.0

Open cdubz opened this issue 1 year ago • 2 comments

I have started work recently on a v2 branch and will try to focus future efforts on moving that forward with some issues with breaking changes. I'll use this issue on tracking for the relevant issues that need to be completed.

v2.0.0

  • [x] #479
  • [x] #301
  • [x] Use browser native datetime handling
  • [x] Create method for managing application-level settings
  • [ ] Replace USE_24_HOUR_TIME_FORMAT with user-level setting
  • [ ] #460
  • [ ] #492
  • [ ] #513
  • [x] #109

Stretch goals

  • [ ] #470
  • [ ] #471
  • [ ] #362
  • [ ] #161
  • [ ] #34

cdubz avatar Aug 04 '22 03:08 cdubz

Will it be totally breaking or is the intention to be able to migrate data from v1 to v2?

whnr avatar Aug 18 '22 20:08 whnr

@whnr my intention is for there to be a migration path using regular database migrations. I'm not being too ambitious here with the 2.0.0 tag so I'm fairly confident that will be achievable.

cdubz avatar Aug 18 '22 20:08 cdubz

@jcgoette @MrApplejuice @OttPeterR curious to get y'alls eyes on the v2 changes (see draft release notes above) w.r.t. your integrations!

cdubz avatar May 05 '23 21:05 cdubz

Thanks! Yeah... the Android app will be "kaputt" when this is made live:

Delete (instead of deactivate) completed timers #109

It was anyway my intention to give this a rework this in the app. I would like to have some time to deploy a hotfix for this if at all possible. Is there a schedule for the major-release by any chance? I think that I can have a fix ready ~until next week~ within in the next 7 days!

MrApplejuice avatar May 05 '23 21:05 MrApplejuice

@MrApplejuice no real rush here. I’m happy to wait til those of you with known integrations are ready to roll.

cdubz avatar May 05 '23 22:05 cdubz

Hey thanks! I still think that you should probably think about setting a deadline for the v2 release, otherwise you might wait a long time should projects become dormant. But nonetheless, thank you for the heads-up! I will try and fix my timer-controls asap!

MrApplejuice avatar May 06 '23 12:05 MrApplejuice

Yeah that’s fair. We’ve got a long vacation coming up so I’m hesitant to drop it and then disappear hah. My rough plan is to release near the end of the month. Let’s say 26 May 👍

cdubz avatar May 06 '23 12:05 cdubz

I'll try to get it spun up this weekend. Looking forward to it!

lenaxia avatar May 06 '23 14:05 lenaxia

Appreciate the heads up! I think those breaking changes should be fine. I like moving more things to the settings rather than env vars. The timer changes seem interesting, would there be a way to use that new architecture to note that a toddler woke up in the middle of the night and not have to get rid of the original sleep timer that spanned the whole night?

As for timeline expectations, I don't have a lot of personal dev time in the next few weeks (~~still working on the 1.16.0 update~~). Unfortunately I might not be able to put sufficient time into this until early June.

OttPeterR avatar May 06 '23 15:05 OttPeterR

Thanks for the heads up!

Are you still accepting PRs for this release? @Cadair has actually started working on fixing the HA integration, but I'm thinking using the new site-wide settings model to create an API endpoint exposing the site's BB version would be useful for my integration.

jcgoette avatar May 07 '23 00:05 jcgoette

@jcgoette sure thing!

cdubz avatar May 07 '23 00:05 cdubz

Oh oops also pinging @btoconnor re: https://github.com/babybuddy/babybuddy/issues/515#issuecomment-1536798129

cdubz avatar May 08 '23 01:05 cdubz

@cdubz I should be able to look at this next week - thanks for the ping!

btoconnor avatar May 09 '23 12:05 btoconnor

Alright! My app has been updated, I released it on GitHub and on the play-store it is currently "in review":

image

And here the GitHub release: https://github.com/MrApplejuice/BabyBuddyAndroid/releases/tag/v2.0.0

This was a crunch to get this out in time... had to change thousands of lines of code. Kind of my fault for not implementing the right level of abstraction from the get-go though! :shrug:

Anyhow, it typically takes a few days for the app store to approve the change. So I would not mind if the release can wait a few more days... but might not be actually necessary. I guess it will take some time anyways until the update proliferates to other servers. Again... dunno :shrug:

Thanks again for the tap on the back so that this could be fixed and rolled out in a timely manner!

MrApplejuice avatar May 25 '23 12:05 MrApplejuice

Well, sorry for the spam, but:

image

So, no need to wait for the Play Store from my side afterall!

MrApplejuice avatar May 25 '23 13:05 MrApplejuice

Well 26 May came and went :smile: I'm still getting readjusted from a vacation and have a few issues to review that may slow down the 2.0.0 release. Takin' a look now :eyes:

cdubz avatar May 27 '23 15:05 cdubz

Ok it looks like the only thing I still want to poke around on is https://github.com/babybuddy/babybuddy/issues/644#issuecomment-1545644400. Will try to do that in the next few days and then move the release along.

cdubz avatar May 27 '23 15:05 cdubz

:wave: just pushed a v2.0.0-beta2 release taking care of some of the bugs that popped up. #644 is good again. Think this is pretty much there...

cdubz avatar Jun 05 '23 00:06 cdubz

Just finding some time now to get a look at this - are there docker images for the beta releases? I'm not seeing them on https://hub.docker.com/r/linuxserver/babybuddy

I can set up something without docker, just a little easier for me to use the images there.

I still haven't found a great workflow for testing the Alexa integration for a parallel instance of the web server...

btoconnor avatar Jun 08 '23 22:06 btoconnor

@btoconnor can you use latest image to test? If not we could ask the LSIO folks if we can get beta release builds somehow.

cdubz avatar Jun 13 '23 22:06 cdubz

FTR I'm about ready for this -- just waiting on finalization in #665 as a last minute addition.

cdubz avatar Jul 05 '23 21:07 cdubz

And we're off! 🎉

https://github.com/babybuddy/babybuddy/releases/tag/v2.0.0

cdubz avatar Jul 10 '23 21:07 cdubz

Leaving some notes here even though the issue is closed. I finally got around to testing this out (sorry for delay). Most of the actions seem to still work fine, except for concluding timers. I'll hopefully get to fix that soon. I'll leave further comments / issues on the alexa repo

btoconnor avatar Jul 14 '23 16:07 btoconnor