babl icon indicating copy to clipboard operation
babl copied to clipboard

PingAgent ignores zero-data ping-packets

Open Crokoking opened this issue 3 years ago • 1 comments

The websocket standard allows for ping-packets with no data. But since the PingAgent uses 0 to determine that it doesn't need to send a pong it essentially ignores it. There is a related issue that encodeData() in the FrameEncoder processes zero-length packets with zero frames and thereby ignores them.

Crokoking avatar Dec 10 '21 08:12 Crokoking

Hi, thanks for the report. We'll look at this when possible. In the mean time, feel free to submit a PR containing a fix.

epickrram avatar Jan 12 '22 13:01 epickrram