Handling for T_Var node for numeric typmod
Description
- We removed plan check from
T_Varnode inresolve_numeric_typmod_from_expfor typmod handling of fixed length datatypes.
Issues Resolved
Task: BABEL-5976
Signed-off-by: yashneet vinayak [email protected]
engine PR: https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/pull/598
Test Scenarios Covered
-
Use case based -
-
Boundary conditions -
-
Arbitrary inputs -
-
Negative test cases -
-
Minor version upgrade tests -
-
Major version upgrade tests -
-
Performance tests -
-
Tooling impact -
-
Client tests -
Check List
- [x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Pull Request Test Coverage Report for Build 16262538621
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
- 4 unchanged lines in 2 files lost coverage.
- Overall coverage increased (+0.006%) to 76.028%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| contrib/babelfishpg_tds/src/backend/tds/tdscomm.c | 2 | 76.23% |
| contrib/babelfishpg_tsql/src/pltsql_coerce.c | 2 | 86.18% |
| <!-- | Total: | 4 |
| Totals | |
|---|---|
| Change from base Build 16228502007: | 0.006% |
| Covered Lines: | 49910 |
| Relevant Lines: | 65647 |