babelfish-for-postgresql
Fix babelfishpg_tsql compile errors
Could you add describe information for this PR ? Is it just for compile success for gcc 11.0 or is it for compiling in LLVM clang ?
Pls also add the gcc -version output from your local test, thanks.
Could you add describe information for this PR ? Is it just for compile success for gcc 11.0 or is it for compiling in LLVM clang ?
Sorry for the late reply! This PR is just for gcc 11.4, I'm not test on gcc11.0.
Pls also add the gcc -version output from your local test, thanks.
Here is my gcc version infomation.
$ gcc --version
gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Pull Request Test Coverage Report for Build 8624848303
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 72.566%
| Totals | |
|---|---|
| Change from base Build 8610250049: | 0.0% |
| Covered Lines: | 41134 |
| Relevant Lines: | 56685 |
💛 - Coveralls
I am x86, and the gcc version is 10.3.1 20210422 (Red Hat 10.3.1-1).
I also encountered the same problem.
Removing pgtsql_base_yydebug can solve it.
/usr/bin/ld: src/pl_comp-2.o:/opt/babelfish_extensions/contrib/babelfishpg_tsql/src/pl_comp-2.c:27: multiple definition ofpltsql_curr_compile_body_lineno'; src/pl_comp.o:/opt/babelfish_extensions/contrib/babelfishpg_tsql/src/pl_comp.c:65: first defined here
/usr/bin/ld: src/backend_parser/gram-backend.o:(.bss+0x20): multiple definition of pgtsql_base_yydebug'; src/backend_parser/parser.o:(.bss+0x0): first defined here
