babel-bot icon indicating copy to clipboard operation
babel-bot copied to clipboard

[Partially done] Add `pr-opened` label to issues when a pr is opened that fixes/refs the issue

Open hzoo opened this issue 8 years ago • 6 comments

why: to make it easy to see which issues already have someone working on them

  • maybe even signal the relevant pr somehow (if active, active x days ago)

name could be different just a suggestion

Parse

  1. just the "fixed tickets" line in our pr template
  2. anything that looks and smells like github ID # and is an issue
  3. (1 || 2) + title of the ticket

hzoo avatar Jan 12 '17 02:01 hzoo

Item 1 in the list above is done, but I'm hitting a super weird issue where the sha for the webhook (what we use for the auth) doesn't match what I'm getting for the payload + secret. Haven't had this problem with any other type of events.

DrewML avatar Jan 12 '17 04:01 DrewML

@DrewML Ihad a similar issue sometime ago. IDK if it helps: http://stackoverflow.com/questions/30269030/github-push-event-signature-dont-match

marcoslhc avatar Jan 12 '17 12:01 marcoslhc

@marcoslhc you rock - thank you! That's probably the issue. Going to give it a shot tonight.

DrewML avatar Jan 12 '17 16:01 DrewML

Done in https://github.com/babel/babel-bot/commit/a36ba808d1ae75e0342c7de1056729d16af70db5 already? I already saw it in action lol

screen shot 2017-01-14 at 6 20 34 pm

hzoo avatar Jan 14 '17 23:01 hzoo

@hzoo Yeah, I had temporarily disabled signature validation and forgot to re-enable it, lol. Going to put in the fix @marcoslhc recommended now.

DrewML avatar Jan 15 '17 20:01 DrewML

Done so far:

  1. just the "fixed tickets" line in our pr template

DrewML avatar Jan 15 '17 21:01 DrewML