PersianDate icon indicating copy to clipboard operation
PersianDate copied to clipboard

Fixed diff method

Open aminmsvi opened this issue 6 years ago • 1 comments

In this branch I did two things:

  • Fixed bug where diff method did not return a negative value when the date was less than other.
  • Added some tests for diff method. Tests for when date is less than, greater than and equals to the other one. I ran eslint and it had lots of errors but I did not fix them since I only wanted to fix diff method and nothing else. Not sure if I had to fix them or not 😅 Also I'm not sure if I should merge this branch with master or develop 😅

aminmsvi avatar Sep 07 '18 21:09 aminmsvi

Coverage Status

Coverage decreased (-0.02%) to 94.118% when pulling d0874b47877f1c7f26315b1be25c7e435abc593d on aminmsvi:fix-diff into be079310276528df8a119535408ea0377336238d on babakhani:master.

coveralls avatar Sep 07 '18 21:09 coveralls