sparklemotion icon indicating copy to clipboard operation
sparklemotion copied to clipboard

sustain pedal

Open SiriusZael opened this issue 1 year ago • 4 comments

  • WIP — MIDI support
  • WIP
  • fix build
  • fix tests
  • WIP

SiriusZael avatar May 24 '23 19:05 SiriusZael

This looks good -- now that you have this set up, would it be possible to modify it to include the following information?

struct MidiInfo {
    int sustainPedalCount, // number of times pedal has been pressed in current session
    bool sustainPedalActive, // whether the pedal is pressed 
    int notesCount, // number of notes which have been pressed in current session
    bool notesActive[88], // 88 size array of whether each note is currently pressed 
    int notesVelocities[88], // 88 size array of note velocities which are currently pressed  
}

@xian I don't have write access to the master branch; it would be great if we could merge this before the tech test next weekend. I will be out of town but I can write a test shader and give @SiriusZael the necessary equipment/cables to test all of this.

bencbartlett avatar Jul 31 '23 22:07 bencbartlett

@xian I don't have write access to the master branch

Oops, sorry about that, added you as a maintainer @bencbartlett!

xian avatar Aug 01 '23 05:08 xian

@SiriusZael — when you're ready could you rebase to take out the 'WIP's in commit comments? I know I've got a couple in there too on midi.

xian avatar Aug 01 '23 05:08 xian

struct MidiInfo {
    ...
    bool notesActive[88], // 88 size array of whether each note is currently pressed 
    int notesVelocities[88], // 88 size array of note velocities which are currently pressed  
}

IIRC glsl arrays aren't well supported by sparklemotion yet so this might be a bit involved. Happy to help on it though!

xian avatar Aug 01 '23 05:08 xian