baa-ableton
baa-ableton
Unit tests had failed because I didn't have a good understanding of the test file/directory structure at the time. The test file I wrote, `null-version-module.tf` is indeed a valid file...
hey @yottta thanks for the feedback i can implement the exact same test case but I will need to write a new function that returns a NewStaticModuleCall instead of RootModuleCallForTesting()...
@apparentlymart you can assign this one to me if you would like
Hey, I could take this up of you would like.
@apparentlymart Are you looking for someone to take a crack at this?
@diofeher I noticed the windows part of this code is different than what I had anticipated: ``` func Unlock(*os.File) error { // the lock is released when Close() is called...
@diofeher hey no worries. I just tested on my Windows machine and the tests are failing due to locks not being released. I'll look into it tomorrow
Hey @diofeher I made sure the tests are passing on my windows machine. It had to do with the Unlock in Windows needing a os.File.close(). I also left a note...
@diofeher I can grab this one
@diofeher just got back from vacation, I'll take a look this week