android-webp-encoder icon indicating copy to clipboard operation
android-webp-encoder copied to clipboard

Support for alpha channel and bug fix

Open KishorJena opened this issue 2 years ago • 9 comments

This commit adds support for the alpha channel and fixes issues

KishorJena avatar Jan 05 '23 12:01 KishorJena

This commit adds support for the alpha channel and fixes issues

Hi, I'm using these changes that you made but still receive the error "Not supported FourCC: ??.V.P.8.". I found out I got the exception when the fcc array is [0], 'V', 'P', '8' (the first is null character) Could you please help me?

Luosoha avatar Jan 21 '24 17:01 Luosoha

This commit adds support for the alpha channel and fixes issues

Hi, I'm using these changes that you made but still receive the error "Not supported FourCC: ??.V.P.8.". I found out I got the exception when the fcc array is [0], 'V', 'P', '8' (the first is null character) Could you please help me?

Hi @Luosoha , Yeah I am aware of that issue and already fixed in my local repo. I think odd/even length is not handled in this PR. Can you share the webp image here.

KishorJena avatar Jan 22 '24 07:01 KishorJena

This commit adds support for the alpha channel and fixes issues

Hi, I'm using these changes that you made but still receive the error "Not supported FourCC: ??.V.P.8.". I found out I got the exception when the fcc array is [0], 'V', 'P', '8' (the first is null character) Could you please help me?

Hi @Luosoha , Yeah I am aware of that issue and already fixed in my local repo. I think odd/even length is not handled in this PR. Can you share the webp image here.

It happens when I add a bitmap with transparent pixels (in my case, I am drawing an image to a canvas and the image has a smaller size than the canvas) to the encoder.

Luosoha avatar Jan 22 '24 07:01 Luosoha

This commit adds support for the alpha channel and fixes issues

Hi, I'm using these changes that you made but still receive the error "Not supported FourCC: ??.V.P.8.". I found out I got the exception when the fcc array is [0], 'V', 'P', '8' (the first is null character) Could you please help me?

Hi @Luosoha , Yeah I am aware of that issue and already fixed in my local repo. I think odd/even length is not handled in this PR. Can you share the webp image here.

It happens when I add a bitmap with transparent pixels (in my case, I am drawing an image to a canvas and the image has a smaller size than the canvas) to the encoder.

We need a base canvas with height, width stored in global chunk VP8X. I think in this PR i have not used that maybe. I have to read the codes again.

I have made separate lib out of this which uses global canvas height width of animation rather frame specfic height width and to properly aligning it we use frame's x,y info. I have not made it public yet due to naming issue.

You can connect me on email or social media so that i can share that with you. you can try and tell me problem still persist

KishorJena avatar Jan 22 '24 14:01 KishorJena

This commit adds support for the alpha channel and fixes issues

Hi, I'm using these changes that you made but still receive the error "Not supported FourCC: ??.V.P.8.". I found out I got the exception when the fcc array is [0], 'V', 'P', '8' (the first is null character) Could you please help me?

Hi @Luosoha , Yeah I am aware of that issue and already fixed in my local repo. I think odd/even length is not handled in this PR. Can you share the webp image here.

It happens when I add a bitmap with transparent pixels (in my case, I am drawing an image to a canvas and the image has a smaller size than the canvas) to the encoder.

We need a base canvas with height, width stored in global chunk VP8X. I think in this PR i have not used that maybe. I have to read the codes again.

I have made separate lib out of this which uses global canvas height width of animation rather frame specfic height width and to properly aligning it we use frame's x,y info. I have not made it public yet due to naming issue.

You can connect me on email or social media so that i can share that with you. you can try and tell me problem still persist

I messaged you to [email protected] :D

Luosoha avatar Jan 23 '24 04:01 Luosoha

OK i just noticed that I can share the info here as well. README.md

KishorJena avatar Jan 23 '24 07:01 KishorJena

Hi, I imported your lib to my gradle but I can't seem to call any of your classes in my code. Do you know what could go wrong here?

Vào Th 3, 23 thg 1, 2024 vào lúc 14:29 Kishor Jena < @.***> đã viết:

OK i just noticed that I can share the info here as well. README.md https://github.com/b4rtaz/android-webp-encoder/files/14019808/README.md

— Reply to this email directly, view it on GitHub https://github.com/b4rtaz/android-webp-encoder/pull/5#issuecomment-1905444286, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7YDS6ZYF6OBAMS4EHTJPDYP5RFTAVCNFSM6AAAAAATR5H5VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGQ2DIMRYGY . You are receiving this because you were mentioned.Message ID: @.***>

Luosoha avatar Jan 25 '24 03:01 Luosoha

It seems I can't download your lib at all, everytime I sync the project it shown that it downloads the lib again.

Vào Th 5, 25 thg 1, 2024 vào lúc 10:17 Sơn Hải Lương < @.***> đã viết:

Hi, I imported your lib to my gradle but I can't seem to call any of your classes in my code. Do you know what could go wrong here?

Vào Th 3, 23 thg 1, 2024 vào lúc 14:29 Kishor Jena < @.***> đã viết:

OK i just noticed that I can share the info here as well. README.md https://github.com/b4rtaz/android-webp-encoder/files/14019808/README.md

— Reply to this email directly, view it on GitHub https://github.com/b4rtaz/android-webp-encoder/pull/5#issuecomment-1905444286, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7YDS6ZYF6OBAMS4EHTJPDYP5RFTAVCNFSM6AAAAAATR5H5VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGQ2DIMRYGY . You are receiving this because you were mentioned.Message ID: @.***>

Luosoha avatar Jan 25 '24 05:01 Luosoha

It seems I can't download your lib at all, everytime I sync the project it shown that it downloads the lib again. Vào Th 5, 25 thg 1, 2024 vào lúc 10:17 Sơn Hải Lương < @.> đã viết: Hi, I imported your lib to my gradle but I can't seem to call any of your classes in my code. Do you know what could go wrong here? Vào Th 3, 23 thg 1, 2024 vào lúc 14:29 Kishor Jena < @.> đã viết: > OK i just noticed that I can share the info here as well. > README.md > https://github.com/b4rtaz/android-webp-encoder/files/14019808/README.md > > — > Reply to this email directly, view it on GitHub > <#5 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AE7YDS6ZYF6OBAMS4EHTJPDYP5RFTAVCNFSM6AAAAAATR5H5VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGQ2DIMRYGY > . > You are receiving this because you were mentioned.Message ID: > @.***> >

maybe due to private repo or something i have to look into it.

KishorJena avatar May 12 '24 10:05 KishorJena